Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added .changeset/funny-kiwis-begin.md
Empty file.
Binary file removed releases/3.26.0-release.png
Binary file not shown.
Binary file removed releases/3.26.1-release.png
Binary file not shown.
Binary file removed releases/3.26.2-release.png
Binary file not shown.
Binary file removed releases/3.26.3-release.png
Binary file not shown.
Binary file removed releases/3.26.4-release.png
Binary file not shown.
Binary file removed releases/3.26.5-release.png
Binary file not shown.
Binary file removed releases/3.26.6-release.png
Binary file not shown.
Binary file removed releases/3.26.7-release.png
Binary file not shown.
Binary file removed releases/3.27.0-release.png
Binary file not shown.
Binary file removed releases/3.28.0-release.png
Binary file not shown.
Binary file removed releases/3.28.1-release.png
Binary file not shown.
Binary file removed releases/3.28.10-release.png
Binary file not shown.
Binary file removed releases/3.28.14-release.png
Binary file not shown.
Binary file removed releases/3.28.15-release.png
Binary file not shown.
Binary file removed releases/3.28.16-release.png
Binary file not shown.
Binary file removed releases/3.28.2-release.png
Binary file not shown.
Binary file removed releases/3.28.3-release.png
Binary file not shown.
Binary file removed releases/3.28.4-release.png
Binary file not shown.
Binary file removed releases/3.28.5-release.png
Binary file not shown.
Binary file removed releases/3.28.6-release.png
Binary file not shown.
Binary file removed releases/3.28.7-release.png
Binary file not shown.
Binary file removed releases/3.28.8-release.png
Binary file not shown.
Binary file removed releases/3.28.9-release.png
Binary file not shown.
Binary file removed releases/3.29.0-release.png
Binary file not shown.
Binary file removed releases/3.29.1-release.png
Binary file not shown.
Binary file removed releases/3.30.0-release.png
Diff not rendered.
Binary file removed releases/3.30.2-release.png
Diff not rendered.
Binary file removed releases/3.30.3-release.png
Diff not rendered.
Binary file removed releases/3.31.0-release.png
Diff not rendered.
Binary file removed releases/3.31.1-release.png
Diff not rendered.
Binary file removed releases/3.31.3-release.png
Diff not rendered.
Binary file removed releases/3.32.0-release.png
Diff not rendered.
Binary file removed releases/3.32.1-release.png
Diff not rendered.
Binary file removed releases/3.33.0-release.png
Diff not rendered.
Binary file removed releases/3.33.1-release.png
Diff not rendered.
Binary file removed releases/3.33.3-release.png
Diff not rendered.
Binary file removed releases/3.34.0-release.png
Diff not rendered.
Binary file removed releases/3.34.2-release.png
Diff not rendered.
Binary file removed releases/3.34.3-release.png
Diff not rendered.
Binary file removed releases/3.34.4-release.png
Diff not rendered.
Binary file removed releases/3.34.5-release.png
Diff not rendered.
Binary file removed releases/3.34.6-release.png
Diff not rendered.
Binary file removed releases/3.34.7-release.png
Diff not rendered.
Binary file removed releases/3.34.8-release.png
Diff not rendered.
Binary file removed releases/3.35.0-release.png
Diff not rendered.
Binary file removed releases/3.35.2-release.png
Diff not rendered.
Binary file removed releases/3.36.0-release.png
Diff not rendered.
Binary file removed releases/3.36.1-release.png
Diff not rendered.
Binary file removed releases/3.36.2-release.png
Diff not rendered.
Binary file removed releases/3.36.3-release.png
Diff not rendered.
Binary file removed releases/3.36.4-release.png
Diff not rendered.
Binary file removed releases/3.36.5-release.png
Diff not rendered.
Binary file removed releases/3.36.6-release.png
Diff not rendered.
Binary file removed releases/template.png
Diff not rendered.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export type { AutocompleteContext, CacheMatchType, FillInAtCursorSuggestion }
* This key is used to track whether the same suggestion is still being displayed.
*/
export function getSuggestionKey(suggestion: FillInAtCursorSuggestion): string {
return `${suggestion.prefix}|${suggestion.suffix}|${suggestion.text}`
return suggestion.id
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ export class GhostInlineCompletionProvider implements vscode.InlineCompletionIte
): FillInAtCursorSuggestion {
if (!suggestionText) {
this.telemetry?.captureSuggestionFiltered("empty_response", telemetryContext)
return { text: "", prefix, suffix }
return { id: crypto.randomUUID(), text: "", prefix, suffix }
}

const processedText = postprocessGhostSuggestion({
Expand All @@ -379,11 +379,11 @@ export class GhostInlineCompletionProvider implements vscode.InlineCompletionIte
})

if (processedText) {
return { text: processedText, prefix, suffix }
return { id: crypto.randomUUID(), text: processedText, prefix, suffix }
}

this.telemetry?.captureSuggestionFiltered("filtered_by_postprocessing", telemetryContext)
return { text: "", prefix, suffix }
return { id: crypto.randomUUID(), text: "", prefix, suffix }
}

private async disposeIgnoreController(): Promise<void> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ describe("AutocompleteTelemetry", () => {
*/
function createSuggestion(index: number): FillInAtCursorSuggestion {
return {
id: `id-${index}`,
text: `text-${index}`,
prefix: `prefix-${index}`,
suffix: `suffix-${index}`,
Expand Down
1 change: 1 addition & 0 deletions src/services/ghost/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export interface PromptResult {
// ============================================================================

export interface FillInAtCursorSuggestion {
id: string
text: string
prefix: string
suffix: string
Expand Down
Loading