feat(retry): add configurable delay and retry limits #4704
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "kilo-code": minor | ||
| --- | ||
|
|
||
| feat(retry): implement configurable delay and max retries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,125 @@ | ||
| import * as os from "os" | ||
| import * as path from "path" | ||
| import * as vscode from "vscode" | ||
| import { Task } from "../Task" | ||
|
|
||
| // Mock dependencies | ||
| vi.mock("delay", () => ({ | ||
| __esModule: true, | ||
| default: vi.fn().mockResolvedValue(undefined), | ||
| })) | ||
|
|
||
| vi.mock("p-wait-for", () => ({ | ||
| default: vi.fn().mockImplementation(async () => Promise.resolve()), | ||
| })) | ||
|
|
||
| vi.mock("vscode", () => { | ||
| return { | ||
| workspace: { | ||
| getConfiguration: vi.fn(() => ({ get: vi.fn() })), | ||
| }, | ||
| env: { | ||
| uriScheme: "vscode", | ||
| language: "en", | ||
| }, | ||
| EventEmitter: vi.fn().mockImplementation(() => ({ | ||
| event: vi.fn(), | ||
| fire: vi.fn(), | ||
| })), | ||
| } | ||
| }) | ||
|
|
||
| describe("Auto-Retry Logic", () => { | ||
| let mockProvider: any | ||
| let mockApiConfig: any | ||
| let mockExtensionContext: any | ||
|
|
||
| beforeEach(() => { | ||
| mockExtensionContext = { | ||
| globalState: { | ||
| get: vi.fn(), | ||
| update: vi.fn(), | ||
| keys: vi.fn().mockReturnValue([]), | ||
| }, | ||
| globalStorageUri: { fsPath: path.join(os.tmpdir(), "test-storage") }, | ||
| secrets: { | ||
| get: vi.fn().mockResolvedValue(undefined), | ||
| store: vi.fn().mockResolvedValue(undefined), | ||
| }, | ||
| extensionUri: { fsPath: "/mock/path" }, | ||
| extension: { packageJSON: { version: "1.0.0" } }, | ||
| } | ||
|
|
||
| mockProvider = { | ||
| getState: vi.fn().mockResolvedValue({ | ||
| autoApprovalEnabled: true, | ||
| requestDelaySeconds: 1, | ||
| requestRetryMax: 3, | ||
| }), | ||
| postMessageToWebview: vi.fn().mockResolvedValue(undefined), | ||
| postStateToWebview: vi.fn().mockResolvedValue(undefined), | ||
| } | ||
|
|
||
| mockApiConfig = { | ||
| apiProvider: "anthropic", | ||
| apiModelId: "claude-3-5-sonnet-20241022", | ||
| } | ||
| }) | ||
|
|
||
| it("should calculate correct delay", async () => { | ||
| const task = new Task({ | ||
| context: mockExtensionContext, | ||
| provider: mockProvider, | ||
| apiConfiguration: mockApiConfig, | ||
| task: "test", | ||
| startTask: false, | ||
| }) | ||
|
|
||
| const delay = (task as any).backoffAndAnnounce(1, new Error("test")) | ||
|
Contributor
There was a problem hiding this comment. WARNING: Test has no assertions — this test calls The comment on line 79 acknowledges this limitation. Consider either:
|
||
| // We can't easily await this because it has a loop with delay() | ||
| // but we can check the internal logic if we expose it or mock delay better | ||
| }) | ||
|
Contributor
There was a problem hiding this comment. WARNING: No-op test — this test creates a Consider either:
|
||
|
|
||
| it("should respect requestRetryMax and alwaysApproveResubmit", async () => { | ||
| const state = { | ||
| autoApprovalEnabled: true, | ||
| alwaysApproveResubmit: true, | ||
| requestRetryMax: 2 | ||
| } | ||
|
|
||
| const shouldRetry = (attempt: number) => | ||
|
Contributor
There was a problem hiding this comment. WARNING: Tests re-implement retry logic locally instead of testing the actual Consider testing the real |
||
| state.autoApprovalEnabled && | ||
| state.alwaysApproveResubmit && | ||
| (state.requestRetryMax === 0 || attempt < state.requestRetryMax) | ||
|
|
||
| // retryAttempt 0 < 2 -> should retry | ||
| expect(shouldRetry(0)).toBe(true) | ||
| // retryAttempt 1 < 2 -> should retry | ||
| expect(shouldRetry(1)).toBe(true) | ||
| // retryAttempt 2 == 2 -> should NOT retry | ||
| expect(shouldRetry(2)).toBe(false) | ||
|
|
||
| // If alwaysApproveResubmit is false, should NOT retry | ||
| state.alwaysApproveResubmit = false | ||
| expect(shouldRetry(0)).toBe(false) | ||
| }) | ||
|
|
||
| it("should handle unlimited retries when requestRetryMax is 0", async () => { | ||
| const state = { | ||
| autoApprovalEnabled: true, | ||
| alwaysApproveResubmit: true, | ||
| requestRetryMax: 0 | ||
| } | ||
|
|
||
| const shouldRetry = (attempt: number) => | ||
| state.autoApprovalEnabled && | ||
| state.alwaysApproveResubmit && | ||
| (state.requestRetryMax === 0 || attempt < state.requestRetryMax) | ||
|
|
||
| expect(shouldRetry(100)).toBe(true) | ||
|
|
||
| // If alwaysApproveResubmit is false, should NOT retry even with unlimited retries | ||
| state.alwaysApproveResubmit = false | ||
| expect(shouldRetry(100)).toBe(false) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: The
retryMaxcheck here only gates the backoff delay — it does NOT gate the actual retry. Lines 3619–3627 (stack.push+continue) execute unconditionally outside thisifblock, meaning whenretryMaxis reached, the backoff is skipped but the retry still happens. This creates an infinite retry loop without any delay.The
stack.push+continueblock should be moved inside thisif, with anelsebranch that either breaks or prompts the user (similar to the empty-assistant-response path at line 3965 which correctly usesif/else).