Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/documents-open-in-editor.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"kilo-code": patch
---

Fix Open in Editor button in Documents viewer
4 changes: 2 additions & 2 deletions packages/kilo-vscode/src/review-utils.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import * as path from "path"
import * as vscode from "vscode"
import { resolveInside } from "./diff/shared/path"
import { inspect } from "util"
Expand Down Expand Up @@ -37,8 +38,7 @@ export function openFileInEditor(
}

export function openRelativeFile(root: string | undefined, relativePath: string, line?: number, column?: number): void {
if (!root) return
const resolved = resolveInside(root, relativePath)
const resolved = path.isAbsolute(relativePath) ? relativePath : root && resolveInside(root, relativePath)
if (!resolved) return
openFileInEditor(resolved, line, column, vscode.ViewColumn.Beside, "DiffPanel")
}
12 changes: 12 additions & 0 deletions packages/kilo-vscode/tests/unit/review-utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,16 @@ describe("openRelativeFile", () => {

expect(execute).not.toHaveBeenCalled()
})

it("opens absolute paths directly, even without a root", () => {
openRelativeFile(undefined, "/repo/app_alpha/README.md")

expect((execute.mock.calls[0]?.[1] as vscode.Uri).fsPath).toBe("/repo/app_alpha/README.md")
})

it("opens absolute paths that fall outside the selected repository", () => {
openRelativeFile("/repo/app_alpha", "/repo/app_beta/README.md")

expect((execute.mock.calls[0]?.[1] as vscode.Uri).fsPath).toBe("/repo/app_beta/README.md")
})
})
Loading