Skip to content

fix(gateway): assume models with empty supported parameters support tools - #14592

Merged
chrarnoldus merged 1 commit into
mainfrom
fix/gateway-optimistic-tool-support
Sep 28, 2026
Merged

chrarnoldus merged 1 commit into
mainfrom
fix/gateway-optimistic-tool-support

Conversation

@chrarnoldus

Copy link
Copy Markdown
Collaborator

Kilo Gateway hides models whose supported_parameters doesn't include tools, since Kilo requires tool calling. A missing list was already treated optimistically, but an empty list ([]) was treated as "no tools". Some router models on https://kilo.ai/api/openrouter/models, e.g. typesafe/jev-router, report an empty list and were therefore hidden.

This adds a shared supportsTools helper in @kilocode/kilo-gateway that treats a missing or empty supported_parameters as tool-capable, and uses it both for the gateway model list (filter + tool_call capability) and the cloud agent catalog (which previously also dropped models with a missing list).

@chrarnoldus chrarnoldus self-assigned this Sep 25, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The shared supportsTools helper is applied consistently to both the gateway model filter and the cloud agent catalog, matching the stated intent that a missing or empty supported_parameters list is treated optimistically as tool-capable. Behavior, tests, and the changeset line up with the PR description; no bugs, security, performance, or memory-leak concerns found in the changed lines.

Files Reviewed (6 files)
  • .changeset/gateway-optimistic-tool-support.md
  • packages/kilo-gateway/src/api/models.ts
  • packages/kilo-gateway/src/index.ts
  • packages/kilo-gateway/test/api/models.test.ts
  • packages/opencode/src/kilocode/cloud/catalog.ts
  • packages/opencode/test/kilocode/cloud/defaults.test.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants