Skip to content

refactor(vscode): remove write-only browser automation state - #14300

Merged
marius-kilocode merged 1 commit into
mainfrom
chore/remove-browser-automation-state
Sep 18, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
chore/remove-browser-automation-state

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

BrowserAutomationService tracked a state field with a setState transition logger. Nothing read the value: there is no getter, no consumer, and no test. It was write-only bookkeeping.

Why This Change Was Made

this.state was written at seven call sites and read only by setState itself to format the State X -> Y log line. Removing it eliminates dead state and keeps the service behavior identical.

User Impact

None. Browser automation still starts, connects, and disables exactly as before. The only removed output is a transition log line that no diagnostic flow consumed.

Evidence

rg -n 'this\.state|setState|BrowserAutomationState' packages/kilo-vscode/src packages/kilo-vscode/webview-ui packages/kilo-vscode/tests shows the only reader of the field was setState in this file; all other matches are unrelated services and test fixtures.

Diff: 1 file changed, 3 insertions(+), 26 deletions(-), net -23 lines.

Checks run from packages/kilo-vscode/:

  • bun run typecheck (pass)
  • bun run lint (pass)
  • bun run test:unit (6133 pass, 2 skip, 0 fail)

Manual self-test in isolated VS Code: enabled Browser Automation, which spawned the Playwright MCP child process under the test backend; disabled it, which removed the process; no extension errors.

@kilo-code-bot

kilo-code-bot Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • packages/kilo-vscode/src/services/browser-automation/browser-automation-service.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 8ce8150 into main Sep 18, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the chore/remove-browser-automation-state branch September 18, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants