refactor(agent-manager): remove unused local comment variant - #14298
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (2 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit ee1ae02)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ee1ae02)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (23 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 18, 2026 13:26
iscekic
approved these changes
Sep 18, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
PRCommentFormdeclared anaction: "local"variant, but no production caller used it. Every production composer passesdiff,line,review,edit,reply, orcreate. Only a test fixture rendered the local variant.Why This Change Was Made
The variant and all of its branches were dead production code. Removing them shrinks the prop union and the component without changing the behavior of the remaining variants. The fixture that rendered the local variant is reduced to its still-valid
linecoverage, and the two i18n keys that only the local variant referenced are removed from every locale.User Impact
None. No user-facing behavior changes.
Evidence
action="local"/action: "local"found the fixture as the only caller. The fixture usage is removed.bun run lintpasses.diff-comment-form,diff-comment-render,inline-comment-form,pr-comments-render,pr-conversation-render,pr-review-render.i18n-unused-keys, after removing the two orphaned keys.bun run typecheckfor the host reports pre-existing environment errors because this worktree has no installed dependencies (missing built SDK, indexing, and memory modules). The changed component and test files report no type errors undercheck-types:webviewandcompile-tests.bun run bundlefails on the missingchromium-bididependency. The fixture tests above exercise those remaining composers.