Skip to content

refactor(agent-manager): remove unused local comment variant - #14298

Merged
marius-kilocode merged 2 commits into
mainfrom
chore/remove-local-comment-variant
Sep 18, 2026
Merged

marius-kilocode merged 2 commits into
mainfrom
chore/remove-local-comment-variant

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

PRCommentForm declared an action: "local" variant, but no production caller used it. Every production composer passes diff, line, review, edit, reply, or create. Only a test fixture rendered the local variant.

Why This Change Was Made

The variant and all of its branches were dead production code. Removing them shrinks the prop union and the component without changing the behavior of the remaining variants. The fixture that rendered the local variant is reduced to its still-valid line coverage, and the two i18n keys that only the local variant referenced are removed from every locale.

User Impact

None. No user-facing behavior changes.

Evidence

  • A repo-wide search for action="local" / action: "local" found the fixture as the only caller. The fixture usage is removed.
  • Net diff: 33 insertions, 169 deletions (-136 lines).
  • bun run lint passes.
  • PR comment fixture tests pass: diff-comment-form, diff-comment-render, inline-comment-form, pr-comments-render, pr-conversation-render, pr-review-render.
  • i18n tests pass, including i18n-unused-keys, after removing the two orphaned keys.
  • Local bun run typecheck for the host reports pre-existing environment errors because this worktree has no installed dependencies (missing built SDK, indexing, and memory modules). The changed component and test files report no type errors under check-types:webview and compile-tests.
  • Manual VS Code self-test (post diff, line, review, reply, and edit comments in an Agent Manager PR) could not run in this worktree because the extension bundle cannot build: bun run bundle fails on the missing chromium-bidi dependency. The fixture tests above exercise those remaining composers.

Comment thread packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentForm.tsx
Comment thread packages/kilo-vscode/tests/fixtures/inline-comment-form.tsx
@kilo-code-bot

kilo-code-bot Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/tests/fixtures/inline-comment-form.tsx 22 Dropped the only coverage for initialBody / cross-form draft isolation
Files Reviewed (2 files)
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentForm.tsx - no issues (dead submitOnEnter/onEscape props now removed, resolving the prior finding)
  • packages/kilo-vscode/tests/fixtures/inline-comment-form.tsx - 1 suggestion

Fix these issues in Kilo Cloud

Previous Review Summary (commit ee1ae02)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit ee1ae02)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 2
Issue Details (click to expand)

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentForm.tsx 107 submitOnEnter and onEscape are now dead props after the local variant removal
packages/kilo-vscode/tests/fixtures/inline-comment-form.tsx 22 Dropped the only coverage for initialBody / cross-form draft isolation
Files Reviewed (23 files)
  • packages/kilo-vscode/tests/fixtures/inline-comment-form.tsx - 1 suggestion
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentForm.tsx - 1 suggestion
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/fa.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts - no issues
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts - no issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit eb54a2f into main Sep 18, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the chore/remove-local-comment-variant branch September 18, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants