Repository navigation
chore: remove small dead leftovers - #14293
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Verified the removals are genuinely dead: Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 18, 2026 13:16
kirillk
approved these changes
Sep 18, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes three pieces of dead code found during a cleanup pass. The diff is net negative (14 insertions, 52 deletions).
Changes
packages/ui/src/kilocode/mermaid/markdown-mermaid.tshad a hardcoded Englishlabelsobject and amergeLabelsfallback. The only caller (packages/ui/src/components/markdown.tsx) always builds a completeMermaidLabelsfrom i18n keys, so every default was shadowed. Removed the default andmergeLabels;renderMermaidnow takes the caller's labels directly.renderMermaidis not exported from any public entry.packages/ui/src/kilocode/mermaid/markdown-mermaid.stories.tsxexported aMermaidstory that duplicates theMarkdownMermaidstory inpackages/kilo-vscode/webview-ui/src/stories/shared.stories.tsx, which the same Storybook loads. Removed only the duplicate export;MermaidErrorandMermaidThemesremain.packages/kilo-vscode/webview-ui/src/components/chat/background-agents.tsexportedchildrenas a pass-through to the privatetaskChildren. ExportedtaskChildrendirectly and updated the importers (ChatView.tsx,SubagentPanel.tsx, and the unit test) rather than keeping an alias.No behavior change. No new helpers or tests.
Evidence
bun run --cwd packages/kilo-vscode lintpasses.bun test tests/unit/background-agents.test.tsfrompackages/kilo-vscode: 24 pass.bun test src/kilocode/mermaidfrompackages/ui: mermaid tests pass. Themarkdown-bidi.test.tscase fails on a pre-existing unbuilt@opencode-ai/coremodule, unrelated to this change.bun run --cwd packages/kilo-vscode typecheckandpackages/uitypecheck report only pre-existing environment errors (unbuilt workspace packages and stale SDK innode_modules), none in touched files.