test(vscode): dedupe childID coverage - #14290
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change replaces the webview-local Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 18, 2026 12:59
iscekic
approved these changes
Sep 18, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates duplicated
childIDcoverage. The extension host helper insrc/kilo-provider/task-session.tsand the webview copy inwebview-ui/src/context/session-utils.tshad byte-identical bodies, so the webview module now re-exports the host helper instead of keeping a second implementation. The duplicateddescribe("childID")block intask-session.test.tsis removed; the identical four cases still run insession-utils.test.tsthrough the re-export, so behavioral coverage is unchanged.The webview already imports pure helpers from
src/kilo-provider/(command-completion), andtask-session.tshas no host-only dependencies, so the cross-boundary import is safe.Net diff: 3 insertions, 31 deletions across 2 files.
Validation (from
packages/kilo-vscode):bun test tests/unit/session-utils.test.ts tests/unit/task-session.test.ts- 98 pass, 0 failbun run lint- passbun run knip- passbun run check-types:webview- 55 errors before and after the change (all pre-existing missing workspace modules), none in the touched filesbun run check-types(host) - pre-existing environment errors only; none in the touched filesbun run test:unit- pre-existing environment failures in unrelated files (missing@kilocode/kilo-memory,@opencode-ai/core/kilocode/zero-id,@xterm/xterm, etc.); the two touched test files pass