Skip to content

test(vscode): dedupe childID coverage - #14290

Merged
marius-kilocode merged 1 commit into
mainfrom
chore/dedupe-childid-tests
Sep 18, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
chore/dedupe-childid-tests

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Consolidates duplicated childID coverage. The extension host helper in src/kilo-provider/task-session.ts and the webview copy in webview-ui/src/context/session-utils.ts had byte-identical bodies, so the webview module now re-exports the host helper instead of keeping a second implementation. The duplicated describe("childID") block in task-session.test.ts is removed; the identical four cases still run in session-utils.test.ts through the re-export, so behavioral coverage is unchanged.

The webview already imports pure helpers from src/kilo-provider/ (command-completion), and task-session.ts has no host-only dependencies, so the cross-boundary import is safe.

Net diff: 3 insertions, 31 deletions across 2 files.

Validation (from packages/kilo-vscode):

  • bun test tests/unit/session-utils.test.ts tests/unit/task-session.test.ts - 98 pass, 0 fail
  • bun run lint - pass
  • bun run knip - pass
  • bun run check-types:webview - 55 errors before and after the change (all pre-existing missing workspace modules), none in the touched files
  • bun run check-types (host) - pre-existing environment errors only; none in the touched files
  • bun run test:unit - pre-existing environment failures in unrelated files (missing @kilocode/kilo-memory, @opencode-ai/core/kilocode/zero-id, @xterm/xterm, etc.); the two touched test files pass

@kilo-code-bot

kilo-code-bot Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change replaces the webview-local childID copy with a re-export of the dependency-free host helper in src/kilo-provider/task-session.ts, and drops the now-duplicate describe("childID") block from task-session.test.ts. I verified the four cases still run in session-utils.test.ts (lines 246-269) through the re-export, that task-session.ts has no host-only imports (safe for the browser webview bundle), and that all existing callers (KiloProvider.ts, session.tsx, TaskToolExpanded.tsx, subagent-tabs.ts) remain type-compatible. Behavioral coverage is unchanged.

Files Reviewed (2 files)
  • packages/kilo-vscode/tests/unit/task-session.test.ts
  • packages/kilo-vscode/webview-ui/src/context/session-utils.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 34340a8 into main Sep 18, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the chore/dedupe-childid-tests branch September 18, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants