Repository navigation
fix(vscode): keep Agent Manager .kilo out of git in subdirectory workspaces - #14274
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summary (commit d162846)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d162846)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (3 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 18, 2026 07:11
WebReflection
approved these changes
Sep 18, 2026
This was referenced Sep 19, 2026
This was referenced Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The Agent Manager could leave a
.kilodirectory untracked in a project.resolveGitDirrequired.gitat the workspace root) and the anchored patterns never matched the nested path, so.kilo/worktrees/showed up ingit status.git initand commit could include it.Why This Change Was Made
ensureGitExcludenow asks git for the exclude file and the repository-relative prefix (--path-format=absolute --git-path info/excludeand--show-prefix), so ignore patterns are anchored to the real.kilolocation for subdirectory workspaces and linked worktrees.reconcilePoolandcreateWorktreeexclude before creating.kilo/worktrees, so a repository that cannot be excluded leaves nothing behind.addExcludeEntrymatches whole lines instead of substrings, so a prefixed entry such aspackages/app/.kilo/worktrees/no longer suppresses the unprefixed repo-root entry.Shared project config under
.kilo/(kilo.jsonc, agents, commands, rules) remains tracked.User Impact
Opening the Agent Manager no longer pollutes
git statusin subdirectory workspaces and no longer creates.kiloin folders that are not git repositories.Evidence
Behavior verified by driving the real
WorktreeManageragainst fresh repositories:.git/info/exclude.kilo/in.gitignore?? sub/.kilo/worktrees/.metadata_never_index!! sub/.kilo/...).kilo/created.kilo/not createdAutomated checks:
bun test tests/unit/worktree-manager.test.ts(134 tests, 2 new)bun test tests/unit/agent-manager-arch.test.tsbun run lintbun run typecheck