feat(cli): log remote session start and end - #14214
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Incremental review since Files Reviewed (2 files)
Previous Review Summaries (3 snapshots, latest commit 1f1acf4)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 1f1acf4)Status: 1 Issue Found | Recommendation: Merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (10 files)
The previously reported issues are no longer present at Fix these issues in Kilo Cloud Previous review (commit 9b7055d)Status: 1 Issue Found | Recommendation: Merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (8 files)
The four findings from the previous review are fixed at Fix these issues in Kilo Cloud Previous review (commit b7924c8)Status: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (7 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
34e2b9e to
9b7055d
Compare
27e4a6c to
1f1acf4
Compare
1f1acf4 to
d6aefae
Compare
d6aefae to
948db04
Compare
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
Changelog for users
kilo remotenow records every session it hosts in two log lines: one when the session starts and one when it ends.Changelog for maintainers
RemoteSessionLogmodule underkilo-sessions/keeps each session's start date in memory and writes both lines through the CLI's existing logger; it adds no file, dependency or telemetry.create_sessionnow waits for the relay to accept the session's ingest bootstrap before the CLI hosts it;attachSessiontakesrequireShareand fails the command when the relay refuses.BootstrapOutcomegains askippedflag, so a bootstrap that never reached the relay (no credentials, ingest disabled) still allows hosting.exit_clidetach, on session deletion, and process-wide fromKiloShutdown, so Ctrl-C still closes the sessions a run started.cli/cmd/remote.tscaptures the instance context before the signal handlers and runs teardown insidecontext.provide, removing the Ctrl-C unhandled-rejection trace; a failed teardown logsremote shutdown failed.RemoteSessionLog.endis a no-op for a session this run did not start, so an adopted session produces no half line.requireSharegate (create_session attach inremote-sender.tsandensureSharedSessioninkilo-sessions.ts) and the shutdown path incli/cmd/remote.ts..changeset/remote-session-log.mdcovers the user-facing change.E2E proof
Owner request
Follow-ups (not changed here)
Open findings (not fixed here)