Skip to content

fix(docs-sync): reuse CROSS_REPO_ACCESS_TOKEN for cloud reviewer ranking - #14123

Merged
iscekic merged 1 commit into
mainfrom
kwf/docs-sync-cross-repo-token
Sep 14, 2026
Merged

iscekic merged 1 commit into
mainfrom
kwf/docs-sync-cross-repo-token

Conversation

@iscekic

@iscekic iscekic commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

What

The docs-sync cloud surface reviewer ranking reads secrets.CROSS_REPO_ACCESS_TOKEN instead of a new DOCS_SYNC_CLOUD_TOKEN.

  • .github/workflows/docs-sync.yml:247CLOUD_REPO_TOKEN now comes from CROSS_REPO_ACCESS_TOKEN.
  • .github/docs-sync/reviewers.mjs, .github/docs-sync/upsert-pr.mjs — the warning and PR body text name the existing secret.
  • .github/docs-sync/surfaces.test.mjs, .github/docs-sync/selftest.mjs — assertions updated.

No new secret is required.

Why

  • The repository already has CROSS_REPO_ACCESS_TOKEN (created 2025-04-15).
  • A second secret adds rotation work and a second failure point.
  • The token is valid and can read Kilo-Org/cloud.

Dry run — the token works

I added a temporary cloud_probe job, dispatched it on this branch, then removed it. Run 34849952873:

GET /user -> 200
cloud commits -> 200
cloud permission -> 200

The secret is non-empty, GET /user returns 200 (the token is not expired), and both Kilo-Org/cloud endpoints used by reviewers.mjs return 200.

Note

Kilo-Org/cloud is public (visibility: public), so the token mainly helps with rate limits. The fallback to the fixed other pair is unchanged when the token is unset or the API fails.

Tests

node .github/docs-sync/selftest.mjs passes. .github/docs-sync/*.test.mjs all pass.

Comment thread .github/workflows/docs-sync.yml
@kilo-code-bot

kilo-code-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
.github/workflows/docs-sync.yml 245 Comment calls CROSS_REPO_ACCESS_TOKEN a read-only token, but the PR only confirms it can read Kilo-Org/cloud; confirm the token's scopes.
Files Reviewed (5 files)
  • .github/workflows/docs-sync.yml - 1 issue
  • .github/docs-sync/reviewers.mjs - 0 issues
  • .github/docs-sync/upsert-pr.mjs - 0 issues
  • .github/docs-sync/surfaces.test.mjs - 0 issues
  • .github/docs-sync/selftest.mjs - 0 issues

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) September 14, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants