fix(docs-sync): reuse CROSS_REPO_ACCESS_TOKEN for cloud reviewer ranking - #14123
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
enabled auto-merge (squash)
September 14, 2026 13:39
marius-kilocode
approved these changes
Sep 14, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The docs-sync cloud surface reviewer ranking reads
secrets.CROSS_REPO_ACCESS_TOKENinstead of a newDOCS_SYNC_CLOUD_TOKEN..github/workflows/docs-sync.yml:247—CLOUD_REPO_TOKENnow comes fromCROSS_REPO_ACCESS_TOKEN..github/docs-sync/reviewers.mjs,.github/docs-sync/upsert-pr.mjs— the warning and PR body text name the existing secret..github/docs-sync/surfaces.test.mjs,.github/docs-sync/selftest.mjs— assertions updated.No new secret is required.
Why
CROSS_REPO_ACCESS_TOKEN(created 2025-04-15).Kilo-Org/cloud.Dry run — the token works
I added a temporary
cloud_probejob, dispatched it on this branch, then removed it. Run 34849952873:The secret is non-empty,
GET /userreturns 200 (the token is not expired), and bothKilo-Org/cloudendpoints used byreviewers.mjsreturn 200.Note
Kilo-Org/cloudis public (visibility: public), so the token mainly helps with rate limits. The fallback to the fixedotherpair is unchanged when the token is unset or the API fails.Tests
node .github/docs-sync/selftest.mjspasses..github/docs-sync/*.test.mjsall pass.