fix(vscode): report failed mention drops and GitHub comment batches - #14113
Merged
Merged
Conversation
insertDrop now returns false when execCommand silently no-ops without changing the editor, so drag callers do not treat a failed insert as a consumed drag. postAllGithub now converts a rejected or synchronously throwing send into the batch failure result, so it stops at the first failure and the review UI clears its pending state instead of hanging.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
The two changes are correct and well-tested: Fix these issues in Kilo Cloud Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 14, 2026 09:04
eshurakov
approved these changes
Sep 14, 2026
…error-handling-prs-0914 # Conflicts: # packages/kilo-vscode/webview-ui/diff-viewer/comments-github.ts
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Two error paths added or extended by the drag-to-mention and GitHub inline-comment work silently reported success when nothing happened.
Why This Change Was Made
insertTokenusesdocument.execCommand("insertText")but always returnedtrue. The surrounding code already notes that execCommand can silently no-op. When that happens,insertDropclaimed the drag was consumed, so the caller did not restore the sidebar order and no mention appeared.postAllGithubdocuments that it stops at the first failure, but a rejectedgithub.sendrejected the whole batch. Its caller has nofinally, sosendAllPendingstayed true and the button remained disabled with no error shown.User Impact
Evidence
bun test tests/unit/comments-github.test.ts tests/unit/use-file-mention.test.ts-> 62 pass, 0 fail.bun run lint-> exit 0.