fix(vscode): keep background subagent cards collapsed and cap reasoning - #14104
Merged
marius-kilocode merged 2 commits intoSep 14, 2026
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Incremental review of Previous Review Summary (commit 3c040da)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3c040da)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (18 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 14, 2026 07:52
eshurakov
approved these changes
Sep 14, 2026
marius-kilocode
deleted the
remove-reasoning-body-animation-async-agents
branch
September 14, 2026 08:10
This was referenced Sep 14, 2026
ausard
pushed a commit
to ausard/kilocode
that referenced
this pull request
Sep 14, 2026
Add a regression test for the background subagent card auto-open rule introduced in Kilo-Org#14104. A pending or running background task must not open on its own, and the streamed input flag wins over later metadata. Extract the two decision helpers into task-tool-state so the rule is unit-testable without rendering the card.
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Background subagent task cards opened while the task was starting and briefly showed
Starting..., then collapsed once the task finished. That open-then-close cycle flickered the transcript. Reasoning blocks inside a background agent transcript also re-expanded and collapsed while the agent streamed.Why This Change Was Made
TaskToolExpandedderived auto-open fromtaskRunning(status), which is true duringpendingwhile the tool arguments, includingbackground, are still streaming. The card therefore opened before it could know the task was asynchronous, andBasicToolseeds its open state only once.runningand the task is not a background task. Background cards stay collapsed and never render theStarting...item. A stored preference, a searchforceOpen, or a manual toggle still wins over the automatic state.reasoningCappedrenders reasoning in a background agent transcript as the existing 120px capped preview that starts open and never auto-expands.User Impact
Starting...status, and reasoning behavior are unchanged.Evidence
bun run typecheck(host and webview): 0 errors.bun run lint: 0 errors.bun run bundle: 0 errors.bun testinpackages/kilo-vscode: 5529 pass, 0 fail, including newbackgroundChildrenunit tests.