Skip to content

feat(vscode): move compaction model setting to Models tab - #14045

Merged
marius-kilocode merged 3 commits into
mainfrom
research-compaction-model-location
Sep 11, 2026
Merged

marius-kilocode merged 3 commits into
mainfrom
research-compaction-model-location

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The compaction model selector lived in Settings > Context > Compaction, while the other per-purpose model selectors (default, small, subagent, autocomplete) live in Settings > Models. Users who look for model routing in the Models tab could not find the compaction model, as requested in #13575.

Why This Change Was Made

The compaction model is a model-routing choice, not a context-tuning option. Putting it next to the other per-purpose selectors keeps all "which model runs X" controls in one place. The Compaction section keeps a short link to Models so users who tune compaction still find it.

User Impact

  • The compaction model now appears in Settings > Models, between Subagent Model and Autocomplete model.
  • Settings > Context > Compaction shows a "Models settings" link that opens the Models tab.
  • Selection, clearing, and config persistence are unchanged.

Evidence

Settings > Models, with the compaction model row:

Models settings tab with the compaction model row between Subagent Model and Autocomplete model

Settings > Context > Compaction, with the link to Models:

Context settings tab showing the compaction section and its link to the Models settings

Verified in an isolated VS Code dev instance with vscode-self-test. Focused unit checks (i18n-keys, i18n-unused-keys, kilo-ui-contract) pass 68 tests. bun run lint and bun run knip pass. The full bun run typecheck is blocked by pre-existing environment errors in unrelated files (missing generated SDK exports and workspace packages); no error references the changed files.

Fixes #13575.

Move the compaction model selector from Context into the Models settings tab, next to the other per-purpose model selectors, and add a link from the Compaction section. Fixes #13575.
@kilo-code-bot

kilo-code-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Incremental review at d1e807dcdad5c8bffb29b0eb83f057366690b5ad. The only changes since the prior review (f64c6646) are regenerated Linux visual-regression baselines, which are CI-owned and excluded from review. The compaction-model source changes were already reviewed and are unchanged.

Files Reviewed (4 files)
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/models-accessible-labels-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/models-autocomplete-open-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/models-speech-to-text-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/settings/settings-panel-chromium-linux.png
Previous Review Summary (commit f64c664)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit f64c664)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (25 files)
  • .changeset/compaction-model-models-tab.md
  • packages/kilo-vscode/webview-ui/src/components/settings/ContextTab.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/ModelsTab.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/Settings.tsx
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fa.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 5bce9f4 into main Sep 11, 2026
27 checks passed
@marius-kilocode
marius-kilocode deleted the research-compaction-model-location branch September 11, 2026 14:52
lambertjosh added a commit that referenced this pull request Sep 14, 2026
Verify domain status refresh against Kilo-Org/cloud#5437 and optional auto-commit against cloud#5529. Follow compaction setting move #14045 and current Mermaid support. Remove MiniMax free IDs absent from the live catalog on 2026-09-14, not merely from the expired cloud#5588 provider override: cloud#5788 and cloud#5797 had continued them through OpenRouter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Move the 'Compaction Model' setting from 'Context' category to 'Models' category

2 participants