perf(ui): render read-only todo checkbox without Kobalte - #14005
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 109.1K · Output: 12K · Cached: 442.2K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 10, 2026 11:35
marius-kilocode
disabled auto-merge
September 10, 2026 11:53
marius-kilocode
enabled auto-merge
September 10, 2026 11:56
WebReflection
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The
todowritetool card rendered every to-do item with a full KobalteCheckboxtree (Root + Input + Control + Indicator + Label + ErrorMessage, plus reactive state per item). The card is read-only, so that work buys no interactivity. A 6-item list cost about 8.9 ms of synchronous render in the isolated harness and 4.8 ms in the real webview, making it an outlier versus other non-diff tool cards.Why This Change Was Made
Replace the read-only Kobalte checkbox with lightweight markup that emits the same DOM slots and accessibility semantics:
data-component="checkbox",checkbox-checkbox-input/control/indicator/label,data-readonly,data-checked, a native checkbox witharia-readonly="true"androle="group", and a label tied byfor/id. The indicator mounts only when checked. No CSS changes.User Impact
No visual change. To-do cards render faster. The check icon for completed items, the unchecked box for pending items, in-progress styling,
data-completed/data-changedattributes, and compact hidden-count rows are all unchanged.Evidence
Storybook harness (
BENCH_MODE=append BENCH_TOOLS=todowrite BENCH_REPEATS=7, median of 3 runs):syncMsIn-app VS Code profiling (isolated Extension Development Host, seeded 6-item
todowritesession, collapse and expand remount, 34 iterations):bun run typecheckandbun run lintpass inpackages/kilo-vscode. Added a Playwright test covering checked states,aria-readonly, label association, indicator count, and that Space does not toggle.