fix(vscode): animate subagent avatar from loading shimmer to identity - #14004
Merged
Conversation
The task card showed a neutral placeholder glyph and the internal tool name
("task Agent") while the subagent started. The avatar slot now renders a
neutral frame shimmer until the child session id is known, then resolves into
the hashed identity glyph in place. The title falls back to the localized
default ("Agent") until subagent_type streams in, so the card never exposes
the tool name.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 5d1e7a2)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5d1e7a2)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Reviewed by grok-4.6 · Input: 41.7K · Output: 4.2K · Cached: 182.5K Review guidance: REVIEW.md from base branch |
The task-avatar descendant rule set transition: filter, and the shorthand reset transition-property, so the color fade never ran on the task card. The base avatar rule applied it to every other AgentAvatar instead. Move both transitions onto the task-avatar selector and clear them under prefers-reduced-motion.
marius-kilocode
enabled auto-merge
September 10, 2026 11:12
WebReflection
approved these changes
Sep 10, 2026
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
When a subagent started, the task card icon slot showed a neutral placeholder glyph (a fixed grey identicon) and then swapped to the child's real colored identicon. The card title read
task Agentbecause the renderer fell back to the internal tool name whilesubagent_typewas still streaming.Why This Change Was Made
The avatar is an identity glyph, not a loading indicator. Using it as the pre-identity placeholder conflated "unknown agent" with "agent with no identity" and produced a visible glyph swap. The title fallback exposed an internal tool name to the user. The default kilo-ui renderer already uses the localized default in this state; this renderer diverged from it.
User Impact
Agentdefault untilsubagent_typestreams in, then switches to<type> Agent. The card never showstask Agent.prefers-reduced-motionfalls back to a static frame and no resolve.Evidence
Manual self-test in an isolated VS Code dev host: spawned two subagents. The second task card transitioned from
data-colorabsent withtask-avatar-frametodata-color=7withtask-avatar-resolveon the lit dots andagent-avatar-pulseon the frame, and the title renderedexplore Agent.