fix(vscode): align Agent Manager section header chevrons - #13991
Merged
Merged
Conversation
The unified icon-button styles treated aria-expanded="true" as a visual active state. Disclosure chevrons set that attribute for accessibility, so expanded Agent Manager section headers and chat task headers showed a persistent background while collapsed ones did not. Explicit data-expanded, data-active, and data-selected attributes continue to drive intended highlights.
Render one chevron glyph and rotate it for the expanded state. The separate chevron-down icon draws at a different weight, so expanded and collapsed section headers looked inconsistent.
eshurakov
approved these changes
Sep 10, 2026
marius-kilocode
enabled auto-merge
September 10, 2026 08:00
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (16 files)
Reviewed by grok-4.6 · Input: 333.5K · Output: 10.9K · Cached: 489.2K Review guidance: REVIEW.md from base branch |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsible Agent Manager section headers rendered inconsistently when expanded. The unified icon-button styles added in #13948 treat
aria-expanded="true"as a visual active state, so every expanded section showed a persistent background block while collapsed sections stayed flat. The separate expanded and collapsed chevrons also draw at different weights, so the expanded arrow looked larger and heavier than the collapsed one.This matters wherever a disclosure chevron uses the shared
IconButton, which also includes the chat task header and the model selector expand toggle.What changed
aria-expandedis a semantic disclosure attribute every toggle must set, so it should not imply a highlight. The ghost-button active rule inpackages/kilo-ui/src/components/icon-button.cssnow keys only off the explicitdata-expanded,data-active, anddata-selectedattributes, which intentional highlights such as the Agent Manager tab bar still pass.Section headers now render a single
chevron-rightglyph and rotate it 90 degrees for the expanded state, so both states share one path and weight. The RTL override keeps the expanded chevron pointing down instead of being mirrored to the left.Evidence
The screenshots render the real
SectionHeaderand shipped styles through this repository's Storybook harness, not a mockup. The two commits on this branch build no test-only code.Computed styles from the same harness confirm the result: expanded and collapsed toggles both report
rgba(0, 0, 0, 0)background, both render#opencode-icon-chevron-rightat 16x16, and the expanded one appliesrotate(90deg). Adata-activetoggle still highlights after a click, so intentional active states are unchanged.Testing
From
packages/kilo-vscode:bun run typecheck, cleanbun run lint, cleanbunx prettier --checkon the touched files, cleanThe
agentmanager-sectionsvisual-regression baselines will change on Linux CI and the workflow regenerates them automatically.How to test