fix(agent-manager): resolve pending board routes early - #13967
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Previous Review Summary (commit 0aad88e)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 0aad88e)Status: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-4.6 · Input: 89.8K · Output: 12.7K · Cached: 460.8K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 9, 2026 12:29
marius-kilocode
changed the title
WebReflection
approved these changes
Sep 9, 2026
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Shared-agent board posts only receive their sender, recipient, and title metadata after the tool result arrives. During streaming, the route can show neutral Agent avatars and incomplete labels, making the wait look stalled.
Why This Change Was Made
Resolve the pending route from the session store instead of waiting for result metadata. Confirmed tool metadata remains authoritative after completion. Partial recipient IDs stay neutral until they match a known session, which avoids color flicker. A lightweight CSS pending cue remains secondary to the data-flow optimization.
User Impact
Pending board posts show the real sender and known recipient avatars and session titles immediately. Unknown or partial recipient IDs remain neutral until resolved. The route remains stable when the tool completes or fails.
Evidence
bun run compilefrompackages/kilo-vscode/bun test tests/unit/board-tool-render.test.ts tests/unit/swarm-board.test.tsfrompackages/kilo-vscode/bun test src/components/board-route.test.ts src/components/agent-avatar-identity.test.ts src/components/basic-tool.test.tsfrompackages/kilo-ui/bun run knip,bun run check-kilocode-change, and formatting checksThe primary change is an optimistic rendering and data-flow optimization. No runtime performance improvement is claimed or measured.