Skip to content

feat(vscode): show PR conversation timeline - #13958

Merged
marius-kilocode merged 8 commits into
mainfrom
improve-pr-sidebar-conversation-context
Sep 9, 2026
Merged

marius-kilocode merged 8 commits into
mainfrom
improve-pr-sidebar-conversation-context

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The Agent Manager PR panel showed comments and review threads, but not the commits and lifecycle events that explain what happened between them. A fix pushed after a review comment, a force push, an approval without text, or the final merge could be missed without opening GitHub.

Why This Change Was Made

GitHub's PullRequest.timelineItems API already provides the Conversation-style history. The panel now requests that timeline together with the existing review-thread data in the same GraphQL request. It does not add a second timeline request or a separate cache. The timeline query is built once at module load and embedded only in the full, active-worktree request. Non-active worktree polls continue to fetch only the summary data.

User Impact

  • The Conversation section now starts with the current PR description.
  • Comments, reviews, commits, force pushes, merge events, close events, and reopen events appear in chronological order.
  • Bodyless approvals and change requests remain visible as compact timeline rows.
  • Consecutive commits by one author collapse into an expandable group.
  • Commit SHAs open the commit on GitHub.
  • PR summary and Fix with Kilo counts continue to include only actionable comments and reviews.
  • PRs with more than the latest 100 timeline items show a link to earlier activity on GitHub.

PR conversation timeline showing grouped commits

PR conversation showing review actions and force-push history

Evidence

  • bun run typecheck
  • bun run lint
  • bun run knip
  • bun run check-kilocode-change
  • bun test tests/unit, 5466 passed, 2 skipped, 0 failed
  • Live gh api graphql verification against open and merged PRs, including commits, reviews, MergedEvent, and ClosedEvent
  • Render fixture coverage for grouped commits, expansion, commit links, lifecycle events, bodyless reviews, the PR description, earlier activity, and existing comment actions

Known limits: the panel requests the latest 100 timeline items. Older activity is currently opened on GitHub, and commit ordering uses the commit timestamp supplied by GitHub.

@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
Previous Review Summaries (3 snapshots, latest commit 93b9fad)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 93b9fad)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/src/agent-manager/AgentManagerProvider.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRPanel.tsx

Previous review (commit 890de4b)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (12 files)
  • packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
  • packages/kilo-vscode/src/agent-manager/pr/timeline.ts
  • packages/kilo-vscode/src/agent-manager/types.ts
  • packages/kilo-vscode/tests/fixtures/pr-conversation-render.tsx
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts
  • packages/kilo-vscode/tests/unit/am-pr-utils.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRPanel.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/agent-manager.ts

Previous review (commit fec32f5)

Status: 4 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 3
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/src/agent-manager/pr/timeline.ts 92 Null timelineItems.nodes entries throw and abort fetchThreads, dropping review threads and conversation for that poll
packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts 707 conversationTotal is GitHub totalCount, compared to filtered items, so “Show earlier activity” can appear when the last: 100 window is complete
packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx 388 “Show earlier activity” is rendered above the PR description, so it reads as activity from before the PR was opened

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css 400 Commit SHA buttons have hover underline but no :focus-visible outline
Files Reviewed (46 files)
  • .changeset/pr-conversation-timeline.md
  • packages/kilo-ui/src/components/icon.tsx
  • packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts - 1 issue
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-types.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
  • packages/kilo-vscode/src/agent-manager/pr/mutate-comment.ts
  • packages/kilo-vscode/src/agent-manager/pr/timeline.ts - 1 issue
  • packages/kilo-vscode/src/agent-manager/types.ts
  • packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx
  • packages/kilo-vscode/tests/fixtures/pr-conversation-render.tsx
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts
  • packages/kilo-vscode/tests/unit/am-pr-utils.test.ts
  • packages/kilo-vscode/tests/unit/pr-conversation-render.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/*.ts (21 locale files)
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRDescription.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRPanel.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRSummary.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRTimelineRow.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-actions.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-comment-state.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • packages/kilo-vscode/webview-ui/src/types/messages/agent-manager.ts
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-conversation-chromium-linux.png

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 81.1K · Output: 3.2K · Cached: 108K

Review guidance: REVIEW.md from base branch main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants