Skip to content

fix(agent-manager): preserve tab focus and order - #13906

Merged
marius-kilocode merged 1 commit into
mainfrom
investigate-worktree-tab-order-focus-offsetof
Sep 8, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
investigate-worktree-tab-order-focus-offsetof

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Agent Manager could lose the last focused Local session in multi-project mode and move a restored Local tab to the end of the tab bar when switching worktrees or projects.

Why This Change Was Made

Local session and draft memory was rejected when the special-tab callback returned false. Restoring an existing session also used the append path, which changed its saved position. Project activation now saves the outgoing tab before changing context, and existing Local sessions skip the append path.

User Impact

Switching between Local, worktrees, and projects preserves the active Local session, pending draft, and tab order.

Evidence

  • bun run compile
  • bun test tests/unit/agent-manager-selection-actions.test.ts tests/unit/tab-order-sync.test.ts tests/unit/agent-manager-arch.test.ts
  • Isolated VS Code Agent Manager verification preserved a middle Local tab and restored it after a worktree round trip.

This change includes focused regression coverage and a patch changeset.

@kilo-code-bot

kilo-code-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/quiet-local-tabs.md
  • packages/kilo-vscode/tests/unit/agent-manager-selection-actions.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/selection-actions.ts

Reviewed by grok-4.6 · Input: 110.8K · Output: 10.5K · Cached: 295.9K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 9f26c6d into main Sep 8, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the investigate-worktree-tab-order-focus-offsetof branch September 8, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants