Skip to content

feat(vscode): support inline pull request reviews - #13903

Merged
marius-kilocode merged 9 commits into
mainfrom
fix-inline-pr-comment-replies
Sep 8, 2026
Merged

marius-kilocode merged 9 commits into
mainfrom
fix-inline-pr-comment-replies

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Reviewing pull request feedback required switching between GitHub, Agent Manager, and the diff viewer. Replies and edits were not available where the code was being reviewed.

Why This Change Was Made

Keep the review loop beside the agent and the changed code. Comment and review requests are bound to the loaded pull request revision, and local suggestion application is guarded against stale or unsaved files.

User Impact

  • Reply, edit, and delete comments from Agent Manager and diff views.
  • Add comments to selected diff lines and submit Comment, Approve, or Request changes reviews.
  • Preview Markdown and GitHub suggestions, then safely apply suggestions to the local worktree without staging, committing, pushing, or resolving the thread.
  • React to comments and keep historical transcript comments read-only until they match live PR data.
  • Preserve drafts and editor focus through refreshes.

Screenshots

Agent Manager PR reply editor

Agent Manager PR files and line review

Agent Manager local suggestion preview

Evidence

  • bun run build:check
  • 1,117 Agent Manager and diff regression tests passed.
  • Isolated VS Code testing passed against a fail-closed GitHub fixture for inline, full-screen, and standalone diff comments, review submission, stale revision rejection, suggestion preview/application, draft retention, and direct deletion.
  • No live GitHub mutations were used for testing.

Auto-merge remains disabled.

Comment thread packages/kilo-vscode/src/agent-manager/pr/PRActions.ts Outdated
Comment thread packages/kilo-vscode/src/agent-manager/pr/mutate-comment.ts Outdated
Comment thread packages/kilo-vscode/src/agent-manager/pr/review-actions.ts Outdated
Comment thread packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts Outdated
Comment thread packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts
Comment thread packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx Outdated
Comment thread packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx Outdated
@kilo-code-bot

kilo-code-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (10 files)
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
  • packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx
  • packages/kilo-vscode/tests/fixtures/pr-review-render.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRComments.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRPanel.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
  • packages/kilo-vscode/webview-ui/diff-viewer/remote-comment-renderer.tsx
Previous Review Summaries (2 snapshots, latest commit c5db396)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit c5db396)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (12 files)
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts
  • packages/kilo-vscode/src/agent-manager/pr/PRActions.ts
  • packages/kilo-vscode/src/agent-manager/pr/mutate-comment.ts
  • packages/kilo-vscode/src/agent-manager/pr/review-actions.ts
  • packages/kilo-vscode/tests/fixtures/diff-comment-render.tsx
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts
  • packages/kilo-vscode/tests/unit/pr-review-actions.test.ts
  • packages/kilo-vscode/tests/unit/pr-review-request.test.ts
  • packages/kilo-vscode/tests/unit/pr-suggestion-actions.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-review-request.ts

Previous review (commit 72a4600)

Status: 8 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 3
WARNING 4
SUGGESTION 1
Issue Details (click to expand)

CRITICAL

File Line Issue
packages/kilo-vscode/src/agent-manager/pr/PRActions.ts 49 gh -f body= treats a leading @ as a filename
packages/kilo-vscode/src/agent-manager/pr/mutate-comment.ts 32 Same @file interpolation on create/edit
packages/kilo-vscode/src/agent-manager/pr/review-actions.ts 235 Same @file interpolation on line comments and reviews

WARNING

File Line Issue
packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts 225 Project mismatch swallows the request with no result
packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts 90 Suggestion tokens are not cleared on reset()
packages/kilo-vscode/webview-ui/agent-manager/pr/pr-review-request.ts 30 Result listener leaks if no matching result arrives
packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx 16 Module-level snapshot map grows without bound

SUGGESTION

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx 130 Full-file diffs rendered with virtualized={false}
Files Reviewed (76 files)
  • packages/kilo-vscode/src/agent-manager/pr/PRActions.ts - 1 issue
  • packages/kilo-vscode/src/agent-manager/pr/mutate-comment.ts - 1 issue
  • packages/kilo-vscode/src/agent-manager/pr/review-actions.ts - 1 issue
  • packages/kilo-vscode/src/agent-manager/pr/suggestion-actions.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts - 2 issues
  • packages/kilo-vscode/src/diff/comment-actions.ts - 0 issues
  • packages/kilo-vscode/src/shared/pr-patch.ts - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentForm.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx - 2 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-review-request.ts - 1 issue
  • Remaining Agent Manager, diff viewer, tests, i18n, changeset, and visual-regression files

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 228.9K · Output: 14.5K · Cached: 467.3K

Review guidance: REVIEW.md from base branch main

Comment thread packages/kilo-vscode/src/shared/pr-patch.ts
…-replies

# Conflicts:
#	packages/kilo-vscode/webview-ui/agent-manager/pr/PRPanel.tsx
Comment thread packages/kilo-vscode/tests/fixtures/diff-comment-render.tsx
Comment thread packages/kilo-vscode/webview-ui/agent-manager/pr/PRFiles.tsx Outdated
marius-kilocode and others added 3 commits September 8, 2026 11:09
…-replies

# Conflicts:
#	packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png
#	packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-chromium-linux.png
#	packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
#	packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx
#	packages/kilo-vscode/tests/unit/am-pr-utils.test.ts
#	packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx
#	packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
#	packages/kilo-vscode/webview-ui/diff-viewer/remote-comment-renderer.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants