Skip to content

fix(vscode): restore /update-from-base requests - #13892

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-update-from-base
Sep 8, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
fix-update-from-base

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

/update-from-base cleared the composer but did not start an update when a selected model was present.

Why This Change Was Made

The selected model came from SolidJS store state and was forwarded as a proxy through the VS Code webview message boundary. Structured cloning rejected the proxy with DataCloneError before the extension host received the request. The submission now sends a plain model object.

User Impact

/update-from-base reaches the owning managed worktree session again while preserving the selected model, agent, and variant.

Evidence

  • Focused session-provider, base-update, and slash-command tests pass, 47 tests and 218 assertions.
  • bun run compile passes extension host and webview type checks, lint, and bundle validation.
  • The regression fixture clones update messages and reproduced the transport failure before this fix.

@kilo-code-bot

kilo-code-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/fix-base-update-transport.md
  • packages/kilo-vscode/tests/fixtures/session-provider-activity.tsx
  • packages/kilo-vscode/webview-ui/src/context/session.tsx

Reviewed by grok-4.6 · Input: 86.7K · Output: 5.9K · Cached: 407.2K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 39e3e7e into main Sep 8, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the fix-update-from-base branch September 8, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants