Skip to content

feat(vscode): add reactions to PR comments - #13881

Merged
marius-kilocode merged 8 commits into
mainfrom
add-pr-comment-reactions
Sep 7, 2026
Merged

marius-kilocode merged 8 commits into
mainfrom
add-pr-comment-reactions

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

PR comments in Agent Manager could not be reacted to, and comments rendered inside diffs had no reaction controls.

Why This Change Was Made

Add GitHub reaction mutations and reaction state to both PR panel comments and diff-rendered comments. The UI keeps reaction pills stable, applies changes optimistically, shows an in-place spinner, and restores the previous state on failure.

User Impact

Users can add or remove GitHub reactions from PR comments, review comments, and comments shown in the diff view. Supported reactions are thumbs up, thumbs down, laugh, hooray, confused, heart, rocket, and eyes.

Screenshots

PR comment reactions in the Agent Manager panel

Compact reaction pills and picker

Evidence

  • bun test --timeout 30000 tests/unit/pr-comments-render.test.ts
  • Focused PR and diff tests: 232 passing
  • bun run check-types
  • bun run check-types:webview
  • bun run lint
  • bun run knip
  • bun run compile

The full unit suite was not used as a gate because unrelated provider tests exceeded the command timeout.

@kilo-code-bot

kilo-code-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (51 files)
  • .changeset/pr-comment-reactions.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-chromium-linux.png
  • packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts
  • packages/kilo-vscode/src/agent-manager/pr/PRActions.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-types.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
  • packages/kilo-vscode/src/agent-manager/types.ts
  • packages/kilo-vscode/src/diff/DiffViewerProvider.ts
  • packages/kilo-vscode/src/diff/pr-poller.ts
  • packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts
  • packages/kilo-vscode/tests/unit/am-pr-utils.test.ts
  • packages/kilo-vscode/tests/unit/diff-viewer-provider.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/DiffPanelCache.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/*.ts (21 locale files)
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRComments.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRReactions.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-comment-state.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
  • packages/kilo-vscode/webview-ui/diff-viewer/DiffViewerApp.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/remote-comment-renderer.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/review-controller.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/agent-manager.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/webview-messages.ts
Previous Review Summaries (2 snapshots, latest commit c13113d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit c13113d)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (51 files)
  • .changeset/pr-comment-reactions.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-chromium-linux.png
  • packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts
  • packages/kilo-vscode/src/agent-manager/pr/PRActions.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-types.ts
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts
  • packages/kilo-vscode/src/agent-manager/types.ts
  • packages/kilo-vscode/src/diff/DiffViewerProvider.ts
  • packages/kilo-vscode/src/diff/pr-poller.ts
  • packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts
  • packages/kilo-vscode/tests/unit/am-pr-utils.test.ts
  • packages/kilo-vscode/tests/unit/diff-viewer-provider.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/DiffPanelCache.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/*.ts (21 locale files)
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRComments.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRReactions.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-comment-state.ts
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts
  • packages/kilo-vscode/webview-ui/diff-viewer/DiffViewerApp.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/remote-comment-renderer.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/review-controller.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/agent-manager.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/webview-messages.ts

Previous review (commit 67baa96)

Status: 2 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 1
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/pr/pr-comment-state.ts 109 Undo of a newly added reaction drops the pill before the poll, so a failed remove cannot restore it

SUGGESTION

File Line Issue
packages/kilo-vscode/src/diff/DiffViewerProvider.ts 306 Diff-viewer reaction errors skip ghErrorReason and can show raw gh stderr
Files Reviewed (51 files)
  • .changeset/pr-comment-reactions.md - 0 issues
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png - 0 issues
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-chromium-linux.png - 0 issues
  • packages/kilo-vscode/src/agent-manager/PRStatusPoller.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/pr-status-bridge.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/pr/PRActions.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-types.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/pr/am-pr-utils.ts - 0 issues
  • packages/kilo-vscode/src/agent-manager/types.ts - 0 issues
  • packages/kilo-vscode/src/diff/DiffViewerProvider.ts - 1 issue
  • packages/kilo-vscode/src/diff/pr-poller.ts - 0 issues
  • packages/kilo-vscode/tests/fixtures/pr-comments-render.tsx - 0 issues
  • packages/kilo-vscode/tests/unit/am-pr-status-bridge.test.ts - 0 issues
  • packages/kilo-vscode/tests/unit/am-pr-utils.test.ts - 0 issues
  • packages/kilo-vscode/tests/unit/diff-viewer-provider.test.ts - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/DiffPanelCache.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/i18n/*.ts (21 locale files) - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRComments.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRConversation.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/PRReactions.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-comment-state.ts - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-panel.css - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/pr/pr-types.ts - 0 issues
  • packages/kilo-vscode/webview-ui/diff-viewer/DiffViewerApp.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/diff-viewer/remote-comment-renderer.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/diff-viewer/review-controller.ts - 0 issues
  • packages/kilo-vscode/webview-ui/src/types/messages/agent-manager.ts - 0 issues
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts - 0 issues
  • packages/kilo-vscode/webview-ui/src/types/messages/webview-messages.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 92.4K · Output: 9.7K · Cached: 222.3K

Review guidance: REVIEW.md from base branch main

marius-kilocode and others added 6 commits September 7, 2026 17:30
# Conflicts:
#	packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png
#	packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-chromium-linux.png
#	packages/kilo-vscode/webview-ui/agent-manager/pr/PRCommentCard.tsx
# Conflicts:
#	packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/agentmanager/pr-panel-comments-200-chromium-linux.png
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants