fix(vscode): keep deleted diff line numbers neutral - #13880
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 48.1K · Output: 7.8K · Cached: 394.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 7, 2026 15:00
WebReflection
approved these changes
Sep 7, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Deleted lines in Pierre diffs color gutter line numbers red, making the line numbers look like changed content.
Why This Change Was Made
Pierre assigns the deletion foreground to changed line-number cells. The diff now inherits the normal gutter color for those cells while keeping deleted-line backgrounds and indicators unchanged.
User Impact
Deleted code remains visibly highlighted, but its line numbers no longer use the deletion color.
Evidence
Before:
After:
Validation
bun test src/pierre/index.test.tsbun run test:visual -- tests/diff-indicators.spec.tsbunx prettier --check src/pierre/index.ts tests/diff-indicators.spec.tsgit diff --check