feat(agent-manager): smoother worktree card removal - #13875
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous Review Summaries (3 snapshots, latest commit a96fa51)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a96fa51)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 781225f)Status: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous review (commit 1506246)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 117.1K · Output: 9.5K · Cached: 405.6K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 7, 2026 14:31
WebReflection
approved these changes
Sep 7, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Removing a worktree card felt slow and unclear. The row stayed still for most of its one-second exit, then faded and collapsed. The completed state also rendered a checkbox chip, which is an invented control: a worktree card has no checkbox and is not a todo item, so ticking it off misrepresented what was happening. The chip was also drawn by placing a 16px sprite icon inside a 12px box, so it rendered as a few pixels of noise.
Why This Change Was Made
The exit now reads as a card leaving the list. The row acknowledges the click on the first frame with a neutral wash, the title is struck through from left to right as it dims, and the card is swept out while the list closes the gap. The checkbox chip is gone.
While removing the chip, two further defects in the leaving state became visible and are also fixed: the bright
Delete?confirmation pill stayed on the row after deletion was acknowledged, and the PR and stats loading skeletons kept pulsing for attention on a row that was already gone. A leaving card now carries no controls and no pending metadata.Colours are monochrome and taken from existing theme greys, so deletion is not styled as a success and the treatment stays correct across themes. The sequence completes in about 360 ms, roughly a third of the previous duration, and the completion fallback timer was shortened to match. Reduced motion shows the final state with no movement.
The recording is played at half speed so each stage is visible. At normal speed the whole sequence takes about 360 ms.
User Impact
Deleting a worktree feels faster and clearer, and the leaving row no longer shows a checkbox, a stale confirmation button, or pulsing skeletons. The confirmation flow is unchanged, and the removal state still appears only after the host acknowledges a successful deletion, so a failed deletion never animates the row away.
Evidence
bun run compilefrompackages/kilo-vscode/bun test tests/unit/worktree-finish.test.ts tests/unit/agent-manager-arch.test.tsfrompackages/kilo-vscode/(76 passed), including a new assertion that the removed row exposes no checkboxbun run lintfrompackages/kilo-vscode/