Skip to content

feat(agent-manager): smoother worktree card removal - #13875

Merged
marius-kilocode merged 4 commits into
mainfrom
enhance-worktree-delete-animation
Sep 7, 2026
Merged

marius-kilocode merged 4 commits into
mainfrom
enhance-worktree-delete-animation

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Removing a worktree card felt slow and unclear. The row stayed still for most of its one-second exit, then faded and collapsed. The completed state also rendered a checkbox chip, which is an invented control: a worktree card has no checkbox and is not a todo item, so ticking it off misrepresented what was happening. The chip was also drawn by placing a 16px sprite icon inside a 12px box, so it rendered as a few pixels of noise.

Why This Change Was Made

The exit now reads as a card leaving the list. The row acknowledges the click on the first frame with a neutral wash, the title is struck through from left to right as it dims, and the card is swept out while the list closes the gap. The checkbox chip is gone.

While removing the chip, two further defects in the leaving state became visible and are also fixed: the bright Delete? confirmation pill stayed on the row after deletion was acknowledged, and the PR and stats loading skeletons kept pulsing for attention on a row that was already gone. A leaving card now carries no controls and no pending metadata.

Colours are monochrome and taken from existing theme greys, so deletion is not styled as a success and the treatment stays correct across themes. The sequence completes in about 360 ms, roughly a third of the previous duration, and the completion fallback timer was shortened to match. Reduced motion shows the final state with no movement.

Removing an Agent Manager worktree card: the row acknowledges the click, the title is struck through and dimmed, then the card sweeps away (recorded at half speed)

The recording is played at half speed so each stage is visible. At normal speed the whole sequence takes about 360 ms.

User Impact

Deleting a worktree feels faster and clearer, and the leaving row no longer shows a checkbox, a stale confirmation button, or pulsing skeletons. The confirmation flow is unchanged, and the removal state still appears only after the host acknowledges a successful deletion, so a failed deletion never animates the row away.

Evidence

  • bun run compile from packages/kilo-vscode/
  • bun test tests/unit/worktree-finish.test.ts tests/unit/agent-manager-arch.test.ts from packages/kilo-vscode/ (76 passed), including a new assertion that the removed row exposes no checkbox
  • bun run lint from packages/kilo-vscode/
  • Removal exercised in the real Agent Manager in an isolated VS Code instance, inspecting the frozen leaving state to confirm no chip, no confirmation pill, and no skeletons remain
  • Dark and light theme token sets checked, plus the reduced-motion path
  • Timing measured live: the wrapper animation ends, the row height reaches zero, and no animations remain running

Comment thread packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css Outdated
@kilo-code-bot

kilo-code-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/tidy-worktree-finish.md
  • packages/kilo-vscode/tests/fixtures/worktree-finish.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
Previous Review Summaries (3 snapshots, latest commit a96fa51)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a96fa51)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • packages/kilo-vscode/tests/fixtures/worktree-finish.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css

Previous review (commit 781225f)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (4 files)
  • .changeset/tidy-worktree-finish.md
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css
  • packages/kilo-vscode/webview-ui/agent-manager/worktree-completion.ts

Previous review (commit 1506246)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css 805 Check-draw selector cannot match sprite-based icons
Files Reviewed (4 files)
  • .changeset/tidy-worktree-finish.md - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/WorktreeItem.tsx - 0 issues
  • packages/kilo-vscode/webview-ui/agent-manager/agent-manager.css - 1 issue
  • packages/kilo-vscode/webview-ui/agent-manager/worktree-completion.ts - 0 issues

Fix these issues in Kilo Cloud


Reviewed by grok-4.6 · Input: 117.1K · Output: 9.5K · Cached: 405.6K

Review guidance: REVIEW.md from base branch main

@marius-kilocode marius-kilocode changed the title feat(agent-manager): polish worktree deletion animation feat(agent-manager): smoother worktree card removal Sep 7, 2026
@marius-kilocode
marius-kilocode merged commit 12c78c6 into main Sep 7, 2026
25 checks passed
@marius-kilocode
marius-kilocode deleted the enhance-worktree-delete-animation branch September 7, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants