fix(vscode): trim Git command output - #13865
Merged
Merged
Conversation
Contributor
Code Review Summarylgtm Status: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by grok-4.6 · Input: 86.8K · Output: 5K · Cached: 222.8K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 7, 2026 11:03
WebReflection
approved these changes
Sep 7, 2026
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Follow-up to #13863. The Git project-root resolver removed the unsupported
--path-formatoption, but its output cleanup still removed only the final newline. Git command output should be normalized with the standard trailing-whitespace operation.Why This Change Was Made
Use
trimEnd()so CRLF output and any trailing command-output whitespace are removed consistently before path validation and canonicalization. This is a one-line review follow-up with no behavior change for normal paths.Evidence
This PR is intentionally limited to the review correction from #13863.