Skip to content

fix(vscode): trim Git command output - #13865

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-indexing-trimend
Sep 7, 2026
Merged

marius-kilocode merged 1 commit into
mainfrom
fix-indexing-trimend

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Follow-up to #13863. The Git project-root resolver removed the unsupported --path-format option, but its output cleanup still removed only the final newline. Git command output should be normalized with the standard trailing-whitespace operation.

Why This Change Was Made

Use trimEnd() so CRLF output and any trailing command-output whitespace are removed consistently before path validation and canonicalization. This is a one-line review follow-up with no behavior change for normal paths.

Evidence

  • Focused project-path tests: 11 passed, 0 failed.
  • Extension typecheck passed.
  • Prettier check passed.

This PR is intentionally limited to the review correction from #13863.

@kilo-code-bot

kilo-code-bot Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

lgtm

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • packages/kilo-vscode/src/agent-manager/project/paths.ts

Reviewed by grok-4.6 · Input: 86.8K · Output: 5K · Cached: 222.8K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 0aecbe2 into main Sep 7, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the fix-indexing-trimend branch September 7, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants