feat(agent-manager): target existing managed worktrees - #13861
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (10 files)
Reviewed by grok-4.6 · Input: 97.1K · Output: 19.6K · Cached: 1.1M Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 7, 2026 10:43
WebReflection
approved these changes
Sep 7, 2026
WebReflection
left a comment
Contributor
There was a problem hiding this comment.
I think concerns around != null instead of !== aren't adding anything to this PR so I'll approve, we should probably add automatically some linter exception when that's needed or have a broader utility that allows that comparison once:
// eslint-ignore-next or something similar
const isNullish = value => value == null;
This was referenced Sep 8, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Agent Manager orchestrators could create sessions only in the caller directory or in newly created worktrees. Review and follow-up sessions therefore could not target an existing managed worktree.
Why This Change Was Made
Add an explicit
worktreeIDstart target resolved fromaction: "list". The target is scoped to the caller project and uses the existing local-session path.User Impact
Fresh sessions can be started in an existing managed worktree without creating a branch, running setup, or deleting the target on failure. Existing requests without
worktreeIDkeep their current behavior. Invalid, unknown, or foreign targets fail without fallback.Evidence
Focused CLI and extension tests, package typechecks, extension compile, isolated VS Code self-test, and generated SDK validation passed.
Related to #13833.