fix(vscode): retry marketplace publishing - #13802
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit c2f1b43)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c2f1b43)Status: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 37.6K · Output: 4.6K · Cached: 131.8K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 4, 2026 15:38
marius-kilocode
disabled auto-merge
September 4, 2026 15:39
marius-kilocode
enabled auto-merge (squash)
September 4, 2026 15:53
WebReflection
approved these changes
Sep 4, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Two consecutive releases stopped on VS Code Marketplace request timeouts. Some platforms were already published, while later platforms and the GitHub VSIX uploads were not reached.
Why This Change Was Made
Use the existing retry helper for Marketplace publishing: three total attempts, waiting 30 seconds before the second attempt and 60 seconds before the third. Add
--skip-duplicateto both VSCE and Open VSX so a retry can continue if an upload succeeded but its response was lost.Each attempt reuses the original VSIX. VSCE 3.9.2 does not expose a publish timeout setting, so this change adds recovery rather than changing the GitHub job timeout.
User Impact
A single transient publish failure no longer immediately stops the release. Duplicate checks remain independent for each marketplace and platform: skipping an existing Marketplace upload still proceeds to Open VSX. Persistent errors still fail after three attempts.
Evidence
After merge, validate with a new patch release from main, checking all eight targets on both marketplaces and the GitHub VSIX assets. Rerunning an old failed job does not include this fix.