fix(cli): remove nonfunctional interactive terminal tool - #13793
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
marius-kilocode
enabled auto-merge
September 4, 2026 13:27
marius-kilocode
disabled auto-merge
September 4, 2026 13:28
eshurakov
approved these changes
Sep 8, 2026
|
I remember it worked before and it was useful to have, specially for sysadmins and devops. A bit sad that instead of fixing it or better yet, avoiding to break it in the first place, the feature is being removed altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The
interactive_terminaltool promises to open an interactive terminal and hand keyboard control to the user. In the failure reported in #13746, it does neither: it starts a real PTY and captures output, but no usable terminal panel appears and keystrokes never reach the process. The transcript shows a tool summary instead of a terminal the user can operate.That defeats the entire purpose of the feature. Login flows, passphrase prompts, installers, and REPLs need human input. Starting those commands without showing an interactive terminal is not useful support for them. It is worse than leaving them unsupported: the agent believes it handed control to the user, while the session stalls until the command exits or times out. The issue reproduces this with a 30-second read that returns
NO-INPUT, including under an isolated configuration.Fixes #13746 by removing the unsupported feature rather than claiming to repair the terminal handoff.
Why This Change Was Made
The feature is incomplete and is being retired now. This is deliberately not an attempt to finish or redesign it. Keeping the tool advertised, merely hiding its panel, or leaving a disabled implementation behind would preserve misleading behavior and unnecessary maintenance work.
Remove the dedicated tool, runtime, terminal UI, transport, API endpoints, generated SDK surface, permissions, and obsolete tests together. Preserve the general PTY infrastructure that other working terminals and smoke tests still use.
The code can be recovered from this PR and Git history later. A future implementation can reuse appropriate parts, but it must actually display the terminal, reliably hand over keyboard input, restore chat input on exit, and prove the real user flow works. No replacement is being built or shipped in this PR.
User Impact
interactive_terminal, including when an old configuration explicitly allows it. Commands that need human keyboard input must run in the user’s own terminal.Evidence
interactive_terminalbut retains Bash and background processes. The live API schema omits the removed routes and retains PTY creation and connection.--miniPTY smoke tests passed rendering, typing, and cursor editing. Focused tests, CLI/TUI/SDK/VS Code consumer typechecks, API coverage checks, and repository guards passed. Lint completed with warnings and no errors.