Skip to content

fix(ci): download release archives before smoke tests - #13786

Merged
marius-kilocode merged 1 commit into
mainfrom
imminent-vanilla
Sep 4, 2026
Merged

fix(ci): download release archives before smoke tests#13786
marius-kilocode merged 1 commit into
mainfrom
imminent-vanilla

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The September 4 prerelease smoke test failed before either eval could run, reporting Gateway proxy or CLI preparation failed. The workflow supplied a GitHub API release-asset URL, but the test runner rejects that URL format. All eight platform validation jobs passed; the end-to-end release gate still blocked publishing.

Why This Change Was Made

Download the selected kilo-linux-x64.tar.gz asset on the runner with authenticated gh release download, then pass its absolute path through the supported KILO_CLI_PATH input. This works with draft releases without passing the release URL or GitHub token to either eval step.

User Impact

Restore the draft-release smoke-test setup without disabling the publish gate. Both existing evals remain required. Leaving the version blank still selects the latest npm release. No shipped application code changes.

Evidence

  • The September 2 prerelease smoke test passed; the linked September 4 failure stops during setup, before producing eval results.
  • Executed the actual updated workflow step locally against draft v7.5.10: download succeeded and the archive contained the CLI binary. Also checked a temporary path containing spaces.
  • Verified that a blank version produces an empty path without downloading, and a nonexistent release fails before publishing a path.
  • Verified both eval steps receive the local archive path and publishing still depends on the smoke-test job.
  • Actionlint/ShellCheck passed with only the existing custom runner-label diagnostic excluded. Prettier, workflow allowlist, annotation checks, and git diff --check passed. Repository lint had zero errors.
  • Root typecheck failed in untouched extension code on missing module/SDK declarations, including @kilocode/kilo-memory/schema and ProviderUsage.
  • Full evals were not run locally because they require CI secrets. After merging, start a new release run to use the updated workflow, and require both smoke tests to pass before publishing.

@kilo-code-bot

kilo-code-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • .github/workflows/smoke-test.yml

Reviewed by grok-4.6 · Input: 38.6K · Output: 7.4K · Cached: 158K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 1c4b414 into main Sep 4, 2026
31 checks passed
@marius-kilocode
marius-kilocode deleted the imminent-vanilla branch September 4, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants