refactor(ui): remove redundant shared CSS - #13742
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 112.2K · Output: 7.6K · Cached: 497K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 10:49
iscekic
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Shared UI CSS retains two duplication exceptions: edit/write metadata repeats declarations already owned by BasicTool, and an obsolete model-selector stylesheet repeats live list styling despite having no current markup producer.
Why This Change Was Made
Delete the redundant metadata block while retaining BasicTool as its owner. Edit, write, and single-file patch headers already render inside
tool-trigger. Keep title sizing, the 8px filename margin, base-only typography/color, hover and bidi behavior, and separate patch-body rules.Delete the unused stylesheet scoped to
[data-component="model-selector-popover"]and remove both imports. The live VS Code selector uses a class-based virtualized tree. Its CSS and the shared list's distinct active/selected contracts remain unchanged.Remove only fingerprints
2bcd290f6a1dfcffand8c547d9472640a65from the duplication allowlist. No scanner, threshold, TSX, or unrelated CSS changes.User Impact
No intended visual change in current repository apps. The change removes 143 production lines and 161 total lines, with zero additions.
The exported Tailwind entrypoint remains available. It already omits
basic-tool.css, and no live repository app consumes it. External Tailwind consumers may lose the deleted metadata overrides; this PR does not establish unchanged styling for that entrypoint.Evidence
Narrow sidebar, metadata hover and action button:
Agent Manager, light theme with expanded patch: