Skip to content

refactor(ui): remove redundant shared CSS - #13742

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-ui-css-cleanup
Sep 3, 2026
Merged

refactor(ui): remove redundant shared CSS#13742
marius-kilocode merged 1 commit into
mainfrom
dedupe-ui-css-cleanup

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Shared UI CSS retains two duplication exceptions: edit/write metadata repeats declarations already owned by BasicTool, and an obsolete model-selector stylesheet repeats live list styling despite having no current markup producer.

Why This Change Was Made

Delete the redundant metadata block while retaining BasicTool as its owner. Edit, write, and single-file patch headers already render inside tool-trigger. Keep title sizing, the 8px filename margin, base-only typography/color, hover and bidi behavior, and separate patch-body rules.

Delete the unused stylesheet scoped to [data-component="model-selector-popover"] and remove both imports. The live VS Code selector uses a class-based virtualized tree. Its CSS and the shared list's distinct active/selected contracts remain unchanged.

Remove only fingerprints 2bcd290f6a1dfcff and 8c547d9472640a65 from the duplication allowlist. No scanner, threshold, TSX, or unrelated CSS changes.

User Impact

No intended visual change in current repository apps. The change removes 143 production lines and 161 total lines, with zero additions.

The exported Tailwind entrypoint remains available. It already omits basic-tool.css, and no live repository app consumes it. External Tailwind consumers may lose the deleted metadata overrides; this PR does not establish unchanged styling for that entrypoint.

Evidence

  • Fresh duplication reports: 21 to 19 pairs; both target fingerprints are gone. The ratchet passes with 19 bounded exceptions.
  • After fast-forwarding to current main: extension typecheck, lint, knip, compile, marker guard, formatting, and diff checks passed. The 50 UI contract tests and 25 model/history/settings accessibility tests passed.
  • Existing tool/list story smoke checks passed, including keyboard-active versus selected rows, list search, BasicTool expansion, and edit/write actions.
  • Isolated VS Code checks covered a 299px sidebar in dark/high-contrast and Agent Manager in dark/light, long mixed-direction filenames, metadata hover, expanded patch content, provider/history search, and model search/ArrowDown/Enter/Escape. Restoring the deleted metadata rules changed none of the computed styles on 67 tool-slot elements.
  • The automated screenshot suite skips macOS. Visual checks used offline fixtures and inspected screenshots, not provider calls. The isolated instance, profiles, HOME, fixture, and temporary server were cleaned up.

Narrow sidebar, metadata hover and action button:

Narrow sidebar retaining truncated metadata, change counts, and the edit hover action

Agent Manager, light theme with expanded patch:

Agent Manager light theme retaining mixed-direction tool headers and expanded patch content

@kilo-code-bot

kilo-code-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • packages/kilo-ui/src/components/message-part.css
  • packages/kilo-ui/src/components/model-selector.css
  • packages/kilo-ui/src/styles/index.css
  • packages/kilo-ui/src/styles/tailwind/index.css
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 112.2K · Output: 7.6K · Cached: 497K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit a77d72e into main Sep 3, 2026
32 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-ui-css-cleanup branch September 3, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants