refactor(vscode): share session tab layout styles - #13741
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 252.1K · Output: 13.4K · Cached: 328.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 10:48
iscekic
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Sidebar, main Agent Manager, and inspector tabs repeat the same equal-width sizing and horizontal-scroll declarations. Duplication fingerprint
9020d3c20123ef72tracks part of this overlap, while the main Agent Manager strip repeats the same mechanics again.Why This Change Was Made
Keep those shared declarations in the existing
session-tabs.css, which both surfaces already load throughchat.css. Group the existing selectors without adding a tab framework, imports, helpers, or JavaScript. Remove only the resolved allowlist entry, with no scanner changes or new exceptions.This removes 50 production CSS lines net, or 62 lines total including the allowlist. The PR contains one focused commit across three files.
User Impact
No intended visual or interaction change. Preserve the 72px minimum, 240px sidebar/main cap versus 180px inspector cap, 36px main versus 32px inspector bars, and the distinct wrapper flex values. Inspector vertical clipping and close, drag, document-tab, and high-contrast rules stay surface-specific. Existing scrolling, focus, and width-freezing JavaScript is unchanged.
Evidence
cf954237c1.Remaining tabs retain their widths after closing the middle tab:
Existing inspector story at narrow, normal, and wide panel sizes in high-contrast light, including horizontal overflow: