refactor(vscode): share context mention parsing and attachments - #13740
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 98.8K · Output: 7.1K · Cached: 175.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 10:46
iscekic
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Git and terminal context mentions duplicate the same standalone-boundary/span parsing and UTF-8 text attachment construction. Maintaining the copies separately risks differences in matching or source metadata.
Why This Change Was Made
Extract only these two algorithms into a browser-safe helper, retaining the feature-specific named wrappers, token constants, filenames, and patterns. Keep the already-shared request lifecycle untouched. This is a small semantic duplicate below the scanner threshold, not a new mention framework.
User Impact
No intended behavior change. Both mentions retain their boundaries, first-match spans, repeated-call behavior, source metadata, and exact encoded content. Git retains its 15-second timeout, repository gate, scope/default context, and disposal reset. Terminal retains its 10-second timeout, embedded-output fallback, empty-content rejection, and distinct disposal behavior.
Evidence
@git-changesand@terminalproducedgit-changes.txtandterminal-output.txt. Verified exact data URLs against real Git and terminal context responses, source ranges, and fixture text containing non-ASCII characters and reserved URL characters. The disposable profile and fixture were removed.Manual check: modify a Git file, print terminal output, submit
Inspect @git-changes and @terminal, and inspect both attachments.