feat(agent-manager): update worktrees from their saved base - #13735
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit e45acd8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e45acd8)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (40 files)
Reviewed by grok-4.6 · Input: 95.5K · Output: 5.8K · Cached: 198.4K Review guidance: REVIEW.md from base branch |
1 task
marius-kilocode
enabled auto-merge
September 3, 2026 10:27
WebReflection
approved these changes
Sep 3, 2026
This was referenced Sep 6, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Updating a managed worktree currently requires writing a Git instruction by hand. Using
main, the current project default, or the worktree branch's own upstream can select the wrong base after branches or project settings change.Why This Change Was Made
Add one agent-task shortcut using the worktree's saved base metadata.
/update-from-base, the worktree context menu, and the Command Palette send the same request to the owning project and worktree session. Existing busy-session handling and tool approvals remain in place.This is not a native Git merge button. There is no new dialog, toolbar icon, setting, background poller, or Apply-conflict integration.
User Impact
Evidence
150 focused tests passed. After resolving the conflict with current
main, the full VS Code unit suite passed: 4,687 passed, 1 skipped, 0 failed. Extension compilation (types, lint, build), knip, change-marker and Markdown guards passed. Documentation type checking passed; documentation lint reported only existing warnings in unchanged files.Isolated VS Code tests exercised actual fetches and merges in disposable repositories with a scripted local provider and normal one-shot Git approvals:
mainwhile Local had an unrelated branch and the project default wasrelease.releasewith no recorded remote, resolved through that base's upstream.The remote revisions were merged rather than stale local base refs. Local's branch and draft remained unchanged, and no stash was created. Final UI checks confirmed the slash action is hidden in Local and visible in worktrees. Test instances and fixtures were cleaned up.
The scripted provider validates routing and Git execution, not a live model's conflict-resolution judgment. Safeguards remain agent instructions rather than native Git enforcement.