Skip to content

fix(agent-manager): show outgoing prompts before approval - #13730

Merged
marius-kilocode merged 1 commit into
mainfrom
show-agent-prompt-in-permission-dialog
Sep 3, 2026
Merged

fix(agent-manager): show outgoing prompts before approval#13730
marius-kilocode merged 1 commit into
mainfrom
show-agent-prompt-in-permission-dialog

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Agent Manager prompt approval showed the action but not the message being sent. The permission dialog now shows the target session and the complete outgoing prompt before approval.

Why This Change Was Made

Reuse the existing permission description and scroll area instead of adding a new renderer or transport contract. The preview and outgoing request use the same trimmed prompt. The prompt permission pattern, auto-approval rules, and approval-before-send order remain unchanged.

User Impact

Multiline prompts retain line breaks and indentation. Long prompts wrap and scroll while Allow once and Deny remain visible. Prompt markup is displayed as literal text. Older requests without a description retain their existing fallback.

Evidence

  • 47 CLI tests and 151 focused extension tests passed, including short, multiline, and long prompts, exact outgoing text, and permission-before-send ordering.
  • CLI typecheck, extension compile (host/webview typechecks and lint), formatting, and relevant guards passed. Targeted CLI lint reported seven existing warnings and no errors.
  • Verified the real permission UI in isolated VS Code with synthetic requests: multiline text, literal HTML/Markdown, a 200-line prompt, a long unbroken word, visible approval buttons, and the legacy fallback. No prompts were sent to live agents during UI verification.

Multiline preview:

Agent Manager permission showing the target session and multiline outgoing prompt

Scrolled to the end of a long prompt, with both approval actions still visible:

Long outgoing prompt scrolled to its final line with Allow once and Deny visible

@kilo-code-bot

kilo-code-bot Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • .changeset/agent-manager-prompt-preview.md
  • packages/kilo-vscode/webview-ui/src/components/chat/PermissionDock.tsx
  • packages/kilo-vscode/webview-ui/src/styles/permission-dock.css
  • packages/opencode/src/kilocode/tool/agent-manager.ts
  • packages/opencode/test/kilocode/agent-manager-tool.test.ts

Reviewed by grok-4.6 · Input: 355.9K · Output: 13.5K · Cached: 346.5K

Review guidance: REVIEW.md from base branch main

@WebReflection WebReflection left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@marius-kilocode
marius-kilocode merged commit 9ffe2a3 into main Sep 3, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the show-agent-prompt-in-permission-dialog branch September 3, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants