fix(agent-manager): show outgoing prompts before approval - #13730
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 355.9K · Output: 13.5K · Cached: 346.5K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 3, 2026 08:57
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Agent Manager prompt approval showed the action but not the message being sent. The permission dialog now shows the target session and the complete outgoing prompt before approval.
Why This Change Was Made
Reuse the existing permission description and scroll area instead of adding a new renderer or transport contract. The preview and outgoing request use the same trimmed prompt. The
promptpermission pattern, auto-approval rules, and approval-before-send order remain unchanged.User Impact
Multiline prompts retain line breaks and indentation. Long prompts wrap and scroll while Allow once and Deny remain visible. Prompt markup is displayed as literal text. Older requests without a description retain their existing fallback.
Evidence
Multiline preview:
Scrolled to the end of a long prompt, with both approval actions still visible: