Skip to content

test(vscode): give session activity integration a 15s timeout - #13708

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-session-activity-test-timeout
Sep 2, 2026
Merged

test(vscode): give session activity integration a 15s timeout#13708
marius-kilocode merged 1 commit into
mainfrom
fix-session-activity-test-timeout

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The SessionProvider activity integration test shares Bun's default 5-second budget between a cold esbuild bundle and a child-process fixture. After #13692 expanded the fixture by 541 added lines, main CI attempt 1 timed out, killed the fixture and esbuild processes, then reported exitCode: null and downstream The service is no longer running errors. Attempt 3 passed unchanged, confirming an intermittent failure.

Why This Change Was Made

Give only this test 15 seconds, matching the existing esbuild dependency integration test. Six concurrent runs on Bun 1.3.14 reproduced the exact 5000ms timeout and SIGTERM/null-exit symptom. With 15 seconds, all six completed their assertions and cleanup in about 5.7 seconds each. This is build/execution overhead, not a teardown hang. The bound leaves headroom without the 120-second wait proposed elsewhere.

This focused fix supersedes only the timeout adjustment in #13592 (commit 916b94f66c67f7c3cb974288e5cc887d66edea4c), not its mention-search feature. The current-main fixture was used throughout; no assertions, sleeps, fixture behavior, or production code change.

User Impact

No runtime behavior change. The extension unit suite can finish this integration test under load without killing the shared esbuild service.

Evidence

  • Temporary timing probes, removed from the diff: unloaded bundles 1.03-1.52s, child execution 1.11-1.48s, cleanup 3-4ms. Under six-process load, bundles took about 4s and every fixture completed with exit code 0 after the fix.
  • Final code on Bun 1.3.14, macOS: focused test repeated 10 times, 10 passed; full extension suite, 4,640 passed, 1 skipped, 0 failed.
  • Extension typecheck, ESLint, formatting, knip, and change-marker checks passed. Root lint finished with 0 errors and existing warnings. Architecture guard passed with 0 boundary violations.
  • Existing architecture checks enforce selected domain/host boundaries, not this fixture's transitive UI graph or build-time budget. UI dependency cleanup is outside this test-only fix. No UI self-test is needed.

@kilo-code-bot

kilo-code-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • packages/kilo-vscode/tests/unit/session-provider-activity.test.ts

Reviewed by grok-4.6 · Input: 64.7K · Output: 2.5K · Cached: 123.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 785b0bc into main Sep 2, 2026
23 checks passed
@marius-kilocode
marius-kilocode deleted the fix-session-activity-test-timeout branch September 2, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants