test(vscode): give session activity integration a 15s timeout - #13708
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 64.7K · Output: 2.5K · Cached: 123.5K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
September 2, 2026 17:42
kirillk
approved these changes
Sep 2, 2026
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The SessionProvider activity integration test shares Bun's default 5-second budget between a cold esbuild bundle and a child-process fixture. After #13692 expanded the fixture by 541 added lines, main CI attempt 1 timed out, killed the fixture and esbuild processes, then reported
exitCode: nulland downstreamThe service is no longer runningerrors. Attempt 3 passed unchanged, confirming an intermittent failure.Why This Change Was Made
Give only this test 15 seconds, matching the existing esbuild dependency integration test. Six concurrent runs on Bun 1.3.14 reproduced the exact 5000ms timeout and SIGTERM/null-exit symptom. With 15 seconds, all six completed their assertions and cleanup in about 5.7 seconds each. This is build/execution overhead, not a teardown hang. The bound leaves headroom without the 120-second wait proposed elsewhere.
This focused fix supersedes only the timeout adjustment in #13592 (commit
916b94f66c67f7c3cb974288e5cc887d66edea4c), not its mention-search feature. The current-main fixture was used throughout; no assertions, sleeps, fixture behavior, or production code change.User Impact
No runtime behavior change. The extension unit suite can finish this integration test under load without killing the shared esbuild service.
Evidence