fix(vscode): clear completed session indicator when its tab is focused

[ehudc]

Fixes #13702

Context

Follow-up to #13504, which added session-activity icons to tabs. A session's completed (✓) indicator persists on its tab even after you open that session to review it. The check only clears on a new turn, revert, resume, submit, or delete — so when a background session finishes, you see the ✓ from another tab, click in to review, and the ✓ stays. That makes it hard to tell, across many tabs, which completed sessions you've already looked at.

Implementation

The activity state for every surface (sidebar tabs, native editor tabs, Agent Manager tabs, worktree cards) is derived from one shared map computed from closeMap (outcomes), statuses, blocked, and submitting — notably not from which tab is focused. The completed outcome is only dropped by clearClose(id), whose callers are new turn / revert / resume / submit / delete.

This adds one more trigger: when currentSessionID changes to a session that is already in the done state, clear its close outcome. It's keyed on the focus transition via on(currentSessionID, ...), deliberately not a continuous effect — so a session that completes while it's already the focused tab still shows its check (it only clears once you navigate away and back). Because all surfaces read the same derived map, clearing in this one place updates every surface.

Scope is intentionally narrow: only done is acknowledged on focus. waiting (needs input/permission) and error are never cleared by focus, since those are unresolved states that must persist until the user actually acts.

Screenshots / Video

clear-done-kilo-tab.mov

How to Test

Manual/local verification

• Ran the affected regression, extended to cover this behavior: bun test tests/unit/session-provider-activity.test.ts — passes. Added assertions cover (a) a session that completes while another tab is focused shows done, then clears when you switch to it, and (b) the guardrail: switching to a tab in the waiting state does not clear it.
• bun run check-types:webview — clean.
• eslint on the two changed files — clean.
• Built the extension and verified in an isolated VS Code dev host: with two sessions, let one finish while focused on the other; the ✓ shows on the background tab and clears on clicking into it; a ⚠ needs-input tab does not clear on click.

Reviewer test steps

1. Open two Kilo sessions (sidebar tabs or Agent Manager).
2. Start a turn in session A, switch to session B.
3. When A completes, confirm B's tab is unaffected and A's tab shows the green ✓.
4. Click A. Confirm the ✓ clears now that A is focused.
5. Trigger a permission/question in a third session while on another tab, then click into it without answering — confirm the amber ⚠ persists (only done clears on focus).

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)

• .changeset/clear-completed-indicator-on-focus.md
• packages/kilo-vscode/tests/fixtures/session-provider-activity.tsx
• packages/kilo-vscode/webview-ui/src/context/session.tsx

---

_{Reviewed by grok-4.6 · Input: 148.1K · Output: 16.4K · Cached: 653.6K}

_{Review guidance: REVIEW.md from base branch main}

[marius-kilocode]

Thanks @ehudc, this makes sense. Opening a finished result is a good point to clear its notification.

I prepared a follow-up locally to make this consistent for worktrees, subagent tabs, returning from Review, and sidebar/editor focus. It shares acknowledgement across views without clearing busy, waiting, or error states, and keeps the actual turn outcome intact. Regression tests, lint, typechecks, and the build pass, and I verified the flows in isolated VS Code.

Can you enable Allow edits from maintainers so I can push the follow-up and finish the checks? It is currently disabled, so these additions are not on this PR yet.

Worktree screenshots: acknowledge only the session that was opened

Before: Checks has been opened, but Implementation is still unread, so the worktree keeps its completion badge.

After opening Implementation: both its badge and the worktree badge clear. The completed result stays visible.

Subagent screenshots: acknowledge completion without changing the running sibling

Before and after opening Analysis. Its completion badge clears; Review remains busy. These screenshots use an isolated test provider.

[marius-kilocode]

I opened #13731 to supersede this PR with the original behavior plus consistent worktree, subagent, sidebar, and editor handling. Thanks for the original fix, clearing the notification when opening the result makes sense.

For future PRs, I recommend enabling Allow edits from maintainers so we can add follow-up fixes directly to your branch instead of opening a replacement.

[ehudc]

@marius-kilocode Thanks, didn't know about that setting for edits, and I'll close this PR with your other branch superseding it.