fix(opencode): announce locally started sessions to the mobile live list - #13681
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 087a802)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 087a802)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Reviewed by grok-4.6 · Input: 64.7K · Output: 15K · Cached: 484.5K Review guidance: REVIEW.md from base branch |
eshurakov
approved these changes
Sep 2, 2026
This was referenced Sep 6, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The live list in the app is fed by the relay registry for each connection.
The registry is built only from attached-session ids on the remote heartbeat.
The CLI attached a remote session only from the app-spawned create_session path.
Locally created sessions connected and sent heartbeats but never announced.
They never appeared in the live list.
Verification
Notes for the reviewer
Dispose of an unowned id is a no-op.
This covers an app-spawned session that exit_cli already detached.