Skip to content

refactor(vscode): share prompt dropdown container styles - #13626

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-vscode-prompt-dropdown-css
Aug 31, 2026
Merged

refactor(vscode): share prompt dropdown container styles#13626
marius-kilocode merged 1 commit into
mainfrom
dedupe-vscode-prompt-dropdown-css

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The file-mention and slash-command dropdown containers repeat the same CSS declarations, recorded as duplication fingerprint aee459acfb62435f.

Why This Change Was Made

Group the two existing class selectors into one rule and prune only the resolved ratchet exception. This removes 13 net production lines without adding classes or abstractions. Item styles, selector specificity, import order, and the later session-mention scrolling override remain unchanged.

User Impact

No intended visual or behavior change. Both dropdowns keep their placement, width, 200px scroll cap, selection styling, and keyboard behavior.

Evidence

  • Duplication report: 38 to 37 pairs, 779 to 765 duplicate lines, 5201 to 5092 duplicate tokens. The final ratchet passes with no new findings or relaxed bounds.
  • 327 existing prompt, mention, slash-command, and CSS architecture tests pass. Typecheck, lint, extension rebuild, formatting, and the change-marker guard pass.
  • Before/after verification in visible isolated VS Code profiles used the actual sidebar @ and / dropdowns. Computed styles, geometry, selection colors, arrow-key scrolling, and Escape dismissal matched. Screenshots were inspected; no command was executed or model prompt sent.
  • The session-picker wrapper remained uncapped and its inner list retained its own 240px scrolling cap. Populated-session scrolling was not exercised because the isolated profile had no past chats. File-search ties changed order between launches; styles matched per file.
  • Temporary profiles were cleaned and the self-test daemon stopped. No screenshots were uploaded.

@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/webview-ui/src/styles/prompt-dropdowns.css
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 126.1K · Output: 3.8K · Cached: 71.4K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 139ee03 into main Aug 31, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-vscode-prompt-dropdown-css branch August 31, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants