Skip to content

refactor(vscode): share marketplace type contracts - #13625

Merged
marius-kilocode merged 1 commit into
mainfrom
dedupe-vscode-marketplace-types
Aug 31, 2026
Merged

refactor(vscode): share marketplace type contracts#13625
marius-kilocode merged 1 commit into
mainfrom
dedupe-vscode-marketplace-types

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Marketplace contracts were declared separately in the extension host and webview, so their wire types could drift.

Why This Change Was Made

Use the existing, import-free host declarations as the canonical source through explicit type-only re-exports. Keep MarketplaceFilters webview-only and leave RawSkill and host result contracts unchanged. Remove only resolved duplication fingerprint 96a848236212dea1; all other ratchet bounds remain unchanged.

User Impact

No runtime behavior or wire-shape changes. Field optionality and discriminated unions are preserved. This removes 61 production lines without adding a shared module or runtime browser dependency.

Evidence

  • Duplication report before/after: 38 to 37 pairs, 779 to 729 duplicated lines, 5201 to 5030 duplicated tokens. Prune and normal ratchet checks pass.
  • All 29 existing marketplace tests pass. Package typecheck, lint, knip, compile (host and browser bundles), marker guard, formatting, and diff checks pass.
  • Fresh visible isolated VS Code smoke loaded 323 public catalogue items. Category filtering returned 9 Business and 159 Data items; MCP filtering returned 126 items. Matching search, empty search results, filter reset, and full skill-description expand/collapse worked.
  • Both local screenshots were visually reviewed. No installation/removal, credentials, or model prompts were used. Installation dialogs were not exercised. The console showed only a url.parse deprecation warning.
  • Missing local dependencies were installed from the frozen lockfile before successful checks. An initial isolated launch failed; retry with shorter temporary paths succeeded. Isolated VS Code and its daemon were stopped, and their profiles were removed.

@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/kilo-vscode/webview-ui/src/types/marketplace.ts
  • script/kilocode-duplication-allowlist.json

Reviewed by grok-4.6 · Input: 64.8K · Output: 4.9K · Cached: 240.5K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 24ed324 into main Aug 31, 2026
33 checks passed
@marius-kilocode
marius-kilocode deleted the dedupe-vscode-marketplace-types branch August 31, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants