Skip to content

fix(vscode): remove unsupported legacy migration - #13605

Merged
marius-kilocode merged 4 commits into
mainfrom
investigate-code-keychain-storage-error
Aug 31, 2026
Merged

fix(vscode): remove unsupported legacy migration#13605
marius-kilocode merged 4 commits into
mainfrom
investigate-code-keychain-storage-error

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

A fresh VS Code profile still ran the unsupported Kilo v5 migration scan during startup and webview synchronization. The scan read VS Code SecretStorage before it knew whether legacy data existed. That can initialize macOS keychain-backed encryption and produce a keychain dialog without a login or credential-save action.

The retired migration also remained available through Settings and the command palette.

Why This Change Was Made

Remove the obsolete migration instead of disabling native credential storage for normal VS Code use. The extension no longer needs to discover, import, or delete legacy Kilo credentials and settings.

Keep the explicit Roo Code session import and its shared session discovery, conversion, and batch-import code. The shared session helpers retain their existing paths to avoid an unrelated file move.

User Impact

  • Stop automatic legacy migration checks and remove the old migration wizard, command, settings actions, and cleanup requests.
  • Leave stored legacy data untouched.
  • Keep Settings → About → Import Sessions from Roo Code, including progress, results, and force re-import.
  • Reject obsolete migration requests without accessing extension storage.

This does not add Zoo-specific storage discovery. The existing Roo discovery list does not include ZooCodeOrganization.zoo-code; Zoo compatibility remains unverified and is outside this cleanup.

Evidence

  • Full extension unit suite: 4,478 passed, 1 skipped, 0 failed across 366 files, including both localization guards.
  • Focused coverage includes all three startup synchronization triggers with zero SecretStorage reads, rejection of obsolete requests, Roo discovery, session conversion, cache behavior, and a synthetic DOM import flow.
  • The DOM flow checks selection, operation scoping, progress, results, confirmation dialogs, and force re-import without real credentials or user session data.
  • Extension type checks, lint, Knip, the change-marker guard, and the full extension build passed.
  • Regenerated source links after removing the obsolete introduction links.

Live VS Code testing was not run to avoid accessing the system keychain. The native macOS dialog's disappearance has not been visually verified. No keychain contents were inspected or changed.

@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (53 files)
  • .changeset/roo-import-only.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/migration/roo-wizard-selecting-chromium-linux.png
  • packages/kilo-docs/source-links.md
  • packages/kilo-vscode/package.json
  • packages/kilo-vscode/src/KiloProvider.ts
  • packages/kilo-vscode/src/extension.ts
  • packages/kilo-vscode/src/kilo-provider/handlers/migration.ts
  • packages/kilo-vscode/src/legacy-migration/legacy-types.ts
  • packages/kilo-vscode/src/legacy-migration/migration-service.ts
  • packages/kilo-vscode/src/legacy-migration/migration-session-progress.ts
  • packages/kilo-vscode/src/legacy-migration/migration-types.ts
  • packages/kilo-vscode/src/legacy-migration/native-mode-defaults.ts
  • packages/kilo-vscode/src/legacy-migration/provider-mapping.ts
  • packages/kilo-vscode/src/services/cli-backend/connection-service.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-followup.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-load-messages.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-route-integration.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-session-refresh.test.ts
  • packages/kilo-vscode/tests/unit/legacy-migration/migration-cache.test.ts
  • packages/kilo-vscode/tests/unit/legacy-migration/native-modes.test.ts
  • packages/kilo-vscode/tests/unit/roo-migration-ui.fixture.tsx
  • packages/kilo-vscode/tests/unit/roo-migration-ui.test.ts
  • packages/kilo-vscode/webview-ui/src/App.tsx
  • packages/kilo-vscode/webview-ui/src/components/migration/MigrationWizard.tsx
  • packages/kilo-vscode/webview-ui/src/components/migration/index.ts
  • packages/kilo-vscode/webview-ui/src/components/migration/migration.css
  • packages/kilo-vscode/webview-ui/src/components/settings/AboutKiloCodeTab.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/Settings.tsx
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fa.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts
  • packages/kilo-vscode/webview-ui/src/stories/migration.stories.tsx
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/migration.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/webview-messages.ts
Previous Review Summaries (2 snapshots, latest commit df75333)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit df75333)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (21 files)
  • packages/kilo-vscode/webview-ui/src/i18n/ar.ts
  • packages/kilo-vscode/webview-ui/src/i18n/br.ts
  • packages/kilo-vscode/webview-ui/src/i18n/bs.ts
  • packages/kilo-vscode/webview-ui/src/i18n/da.ts
  • packages/kilo-vscode/webview-ui/src/i18n/de.ts
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/i18n/es.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fa.ts
  • packages/kilo-vscode/webview-ui/src/i18n/fr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ja.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ko.ts
  • packages/kilo-vscode/webview-ui/src/i18n/nl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/no.ts
  • packages/kilo-vscode/webview-ui/src/i18n/pl.ts
  • packages/kilo-vscode/webview-ui/src/i18n/ru.ts
  • packages/kilo-vscode/webview-ui/src/i18n/th.ts
  • packages/kilo-vscode/webview-ui/src/i18n/tr.ts
  • packages/kilo-vscode/webview-ui/src/i18n/uk.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zh.ts
  • packages/kilo-vscode/webview-ui/src/i18n/zht.ts

Previous review (commit 91d2be3)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (33 files)
  • .changeset/roo-import-only.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/migration/roo-wizard-selecting-chromium-linux.png
  • packages/kilo-docs/source-links.md
  • packages/kilo-vscode/package.json
  • packages/kilo-vscode/src/KiloProvider.ts
  • packages/kilo-vscode/src/extension.ts
  • packages/kilo-vscode/src/kilo-provider/handlers/migration.ts
  • packages/kilo-vscode/src/legacy-migration/legacy-types.ts
  • packages/kilo-vscode/src/legacy-migration/migration-service.ts
  • packages/kilo-vscode/src/legacy-migration/migration-session-progress.ts
  • packages/kilo-vscode/src/legacy-migration/migration-types.ts
  • packages/kilo-vscode/src/legacy-migration/native-mode-defaults.ts
  • packages/kilo-vscode/src/legacy-migration/provider-mapping.ts
  • packages/kilo-vscode/src/services/cli-backend/connection-service.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-followup.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-load-messages.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-route-integration.test.ts
  • packages/kilo-vscode/tests/unit/kilo-provider-session-refresh.test.ts
  • packages/kilo-vscode/tests/unit/legacy-migration/migration-cache.test.ts
  • packages/kilo-vscode/tests/unit/legacy-migration/native-modes.test.ts
  • packages/kilo-vscode/tests/unit/roo-migration-ui.fixture.tsx
  • packages/kilo-vscode/tests/unit/roo-migration-ui.test.ts
  • packages/kilo-vscode/webview-ui/src/App.tsx
  • packages/kilo-vscode/webview-ui/src/components/migration/MigrationWizard.tsx
  • packages/kilo-vscode/webview-ui/src/components/migration/index.ts
  • packages/kilo-vscode/webview-ui/src/components/migration/migration.css
  • packages/kilo-vscode/webview-ui/src/components/settings/AboutKiloCodeTab.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/Settings.tsx
  • packages/kilo-vscode/webview-ui/src/i18n/en.ts
  • packages/kilo-vscode/webview-ui/src/stories/migration.stories.tsx
  • packages/kilo-vscode/webview-ui/src/types/messages/extension-messages.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/migration.ts
  • packages/kilo-vscode/webview-ui/src/types/messages/webview-messages.ts

Reviewed by grok-4.6 · Input: 151.2K · Output: 17.5K · Cached: 1.3M

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode force-pushed the investigate-code-keychain-storage-error branch from 91d2be3 to fc62b89 Compare August 31, 2026 11:17
@marius-kilocode
marius-kilocode force-pushed the investigate-code-keychain-storage-error branch from df75333 to 49af575 Compare August 31, 2026 14:01
@marius-kilocode
marius-kilocode merged commit 207c37e into main Aug 31, 2026
25 of 26 checks passed
@marius-kilocode
marius-kilocode deleted the investigate-code-keychain-storage-error branch August 31, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants