Skip to content

fix(vscode): preserve background agent spinner animation - #13604

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-background-agent-spinner-reset
Aug 31, 2026
Merged

fix(vscode): preserve background agent spinner animation#13604
marius-kilocode merged 1 commit into
mainfrom
fix-background-agent-spinner-reset

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

What Problem This Solves

Expanded background-agent spinners restarted on every one-second job refresh. The shared spinner animation was correct, but the list used newly created agent objects as Solid list identities, replacing the rows and SVGs each time.

Why This Change Was Made

Key expanded rows by job ID and read current job data through a non-keyed Show, matching the existing collapsed preview. This preserves the spinner without changing shared animation styles or polling frequency. Titles, status, and row actions still use the latest snapshot.

User Impact

Background-agent spinners animate continuously while the list is expanded. Completed agents still show their final status and Dismiss control.

Evidence

  • The browser regression failed before the fix because the first refresh detached the original SVG. It passes after the fix, including three repeated runs, and verifies updated titles and completion state.
  • Extension compilation, host/webview typechecks, lint, 22 focused unit tests, both background-agent browser tests, Knip, and the change-marker guard pass.
  • Isolated VS Code verification preserved the original SVGs and animation objects through four one-second refreshes. Completing one job updated its icon, status, and controls while the other spinner continued.
  • UI verification used synthetic responses matched to real outgoing request IDs, with no model requests or credentials. Backend job execution was not tested. The screenshot shows the completion state; animation continuity was measured separately because screenshot capture temporarily disables animations.

Expanded background agents showing one running agent and one completed agent

@kilo-code-bot

kilo-code-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/smooth-background-agent-spinner.md
  • packages/kilo-vscode/tests/accessibility.spec.ts
  • packages/kilo-vscode/webview-ui/src/components/chat/BackgroundAgents.tsx

Reviewed by grok-4.6 · Input: 59K · Output: 10.9K · Cached: 282.9K

Review guidance: REVIEW.md from base branch main

</Button>
</Show>
</div>
<For each={visible().map((agent) => agent.jobID)}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice way to enforce keys!

@marius-kilocode
marius-kilocode merged commit 5651135 into main Aug 31, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the fix-background-agent-spinner-reset branch August 31, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants