fix(vscode): preserve background agent spinner animation - #13604
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 59K · Output: 10.9K · Cached: 282.9K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 31, 2026 10:43
| </Button> | ||
| </Show> | ||
| </div> | ||
| <For each={visible().map((agent) => agent.jobID)}> |
Contributor
There was a problem hiding this comment.
nice way to enforce keys!
WebReflection
approved these changes
Aug 31, 2026
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Expanded background-agent spinners restarted on every one-second job refresh. The shared spinner animation was correct, but the list used newly created agent objects as Solid list identities, replacing the rows and SVGs each time.
Why This Change Was Made
Key expanded rows by job ID and read current job data through a non-keyed
Show, matching the existing collapsed preview. This preserves the spinner without changing shared animation styles or polling frequency. Titles, status, and row actions still use the latest snapshot.User Impact
Background-agent spinners animate continuously while the list is expanded. Completed agents still show their final status and Dismiss control.
Evidence