Skip to content

fix(vscode): prevent drained questions from reappearing - #13547

Merged
marius-kilocode merged 1 commit into
mainfrom
fix-disabled-snapshot-prompt-race
Aug 28, 2026
Merged

fix(vscode): prevent drained questions from reappearing#13547
marius-kilocode merged 1 commit into
mainfrom
fix-disabled-snapshot-prompt-race

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Settings saves reject pending questions and clear the UI, but a delayed recovery scan can replay an old question before the rejection SSE arrives.

Invalidate recovery immediately after a successful rejection or NotFound response, using the existing revision guard. Keep the fix to one production line; snapshot backend behavior is unchanged.

The focused regression covers both outcomes and verifies invalidation before the clear notification. It fails without the fix and passes with it. All 19 focused tests, extension/webview typechecks, lint, knip, and the change-marker guard pass. The live VS Code heavy-load scenario was not exercised.

@kilo-code-bot

kilo-code-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/clear-drained-question-recovery.md
  • packages/kilo-vscode/src/services/cli-backend/connection-service.ts
  • packages/kilo-vscode/tests/unit/connection-service-question.test.ts

Reviewed by grok-4.6 · Input: 52.2K · Output: 7.1K · Cached: 317.2K

Review guidance: REVIEW.md from base branch main

@WebReflection WebReflection left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@marius-kilocode
marius-kilocode merged commit 25bed68 into main Aug 28, 2026
24 checks passed
@marius-kilocode
marius-kilocode deleted the fix-disabled-snapshot-prompt-race branch August 28, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants