fix(agent-manager): correct activity indicators after recovery - #13543
Merged
Conversation
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit d65caf8)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d65caf8)Status: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (28 files)
Reviewed by grok-4.6 · Input: 80K · Output: 5.3K · Cached: 140.8K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 28, 2026 11:47
WebReflection
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Agent Manager could keep showing a failure after the agent resumed. A concurrent worktree operation could also replace a warning icon with a spinner while retaining the warning color. Optional review suggestions were treated as required input, so a completed task could appear to need attention.
Why This Change Was Made
New
busyandretryevents now clear stale terminal outcomes even when no idle event occurs between attempts. Error messages remain in the transcript, and a failure that ends in idle still shows an error. Worktree icons and colors use the same activity state, with required input and errors taking priority over concurrent operations.Suggestions remain available but no longer count as blocking input. Questions and permission requests still require attention.
User Impact
Evidence
Verified the actual Agent Manager webview in isolated VS Code using synthetic lifecycle events. Scenarios covered recovery without an idle transition, retry recovery, terminal failures, completion, required questions, concurrent worktree operations, and optional review suggestions. No live provider failures or model requests were used. Automated regressions exercise the real session provider and rendered worktree/tab indicators.
Resumed work uses the neutral spinner:
Worktree and session-tab spinners were measured at 16 x 16 px in the rebuilt extension. The CSS usage guard now includes the shared activity component so its sizing rule is not incorrectly treated as unused.
Short explanations on worktree and session-tab hover:
An optional review suggestion remains available while the task stays completed: