fix(vscode): restore past session references - #13530
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Previous Review Summary (commit 5d1313f)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 5d1313f)Status: No Issues Found | Recommendation: Merge Files Reviewed (8 files)
Reviewed by grok-4.6 · Input: 67.5K · Output: 7.9K · Cached: 514.6K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 28, 2026 06:52
WebReflection
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Past-chat references could disappear because the extension requested only 50 sessions before filtering. Rendering thousands of matches also caused typing delays. Inaccessible saved project or sandbox paths could fail the entire family lookup.
Why This Change Was Made
Request up to 5,000 recently updated, non-archived root chats through the existing family-scoped session API. Search those candidates by title and worktree name, then render only the best 50 matches. This replaces the unbounded numeric sentinel with a practical candidate-count limit without adding an endpoint or pagination. Inaccessible saved directories are skipped while other filesystem errors still propagate.
User Impact
The sidebar and Agent Manager can find older chats beyond the previous 50-session cutoff without rendering the full candidate list. The history cap applies across the worktree family, not separately to each worktree. Chats outside the latest 5,000 are intentionally unavailable in this picker. This bounds returned candidates and client-side history, not all backend query allocations.
Evidence