fix(vscode): prevent empty queued messages - #13528
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (9 files)
Reviewed by grok-4.6 · Input: 231.7K · Output: 29.9K · Cached: 783.4K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 28, 2026 06:54
WebReflection
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Queued follow-ups can show only a “Queued” label and a remove button, with no prompt text. The earlier fix in #13176 preserved text through metadata-only confirmation, but synthetic attachment context and partial message snapshots could still replace it.
Why This Change Was Made
Attachments are expanded into synthetic text before the visible prompt part arrives. Matching only by part type mistakes this internal context for confirmation of the user’s text. A snapshot can also observe only the first persisted parts.
Preserve unresolved optimistic parts through both event and snapshot reconciliation. Do not discard already-confirmed text when a stale prefix resolves the last pending attachment. Keep snapshots authoritative once optimism has retired.
Empty and internal queued user rows are omitted without deleting their messages or changing assistant-parent grouping. Reads still subscribe to reactive parts when a cached value exists, so hidden rows can appear when their visible text arrives.
User Impact
Evidence
Reported behavior before the fix:
bun run test:unit --timeout 30000. The initial run hit two existing five-second timeouts during a concurrent local build; no test timeout settings were changed in the code.Manual verification: while a reply runs, queue a follow-up with an
@filereference. Confirm its text stays visible, then switch away and back and confirm it is still present without duplicate or empty queue rows.