Skip to content

fix(ci): skip unsupported PTY smoke targets - #13454

Merged
marius-kilocode merged 1 commit into
mainfrom
evaluate-agent-manager-panel-defaults
Aug 26, 2026
Merged

fix(ci): skip unsupported PTY smoke targets#13454
marius-kilocode merged 1 commit into
mainfrom
evaluate-agent-manager-panel-defaults

Conversation

@marius-kilocode

@marius-kilocode marius-kilocode commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

What Problem This Solves

The release PTY smoke test was enabled for Alpine/musl and Windows ARM64 before those packaged targets had compatible PTY libraries. The next publish would fail during target validation even though the ordinary CLI checks remain valid.

Why This Change Was Made

Local OrbStack Docker testing ran the exact merged repository PTY smoke implementation:

  • Debian/glibc x64 and ARM64 passed with the current bun-pty@0.4.8.
  • Alpine/musl x64 and ARM64 failed with the current dependency.
  • Replacing it with bun-pty@0.4.10 made both Alpine smoke tests pass.
  • Windows ARM64 still requires an ARM64-compatible PTY DLL.

This PR keeps PTY smoke coverage for macOS, glibc Linux, and Windows x64. Alpine and Windows ARM64 continue to run version, model, and artifact checks without claiming PTY support.

Remaining platform and rollout work is tracked in issue #13451.

User Impact

Release validation no longer blocks on PTY checks for unsupported targets. No runtime behavior or user-facing terminal behavior changes in this PR.

Evidence

This PR is the temporary release-gating fix; issue #13451 remains open for the compatibility work.

@kilo-code-bot

kilo-code-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

lgtm

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • .github/workflows/publish.yml

Reviewed by grok-4.6 · Input: 32.4K · Output: 5K · Cached: 247.8K

Review guidance: REVIEW.md from base branch main

@marius-kilocode
marius-kilocode merged commit 472c301 into main Aug 26, 2026
31 checks passed
@marius-kilocode
marius-kilocode deleted the evaluate-agent-manager-panel-defaults branch August 26, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants