fix(ci): skip unsupported PTY smoke targets - #13454
Merged
Merged
Conversation
Contributor
Code Review Summarylgtm Status: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by grok-4.6 · Input: 32.4K · Output: 5K · Cached: 247.8K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 26, 2026 09:10
WebReflection
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
The release PTY smoke test was enabled for Alpine/musl and Windows ARM64 before those packaged targets had compatible PTY libraries. The next publish would fail during target validation even though the ordinary CLI checks remain valid.
Why This Change Was Made
Local OrbStack Docker testing ran the exact merged repository PTY smoke implementation:
bun-pty@0.4.8.bun-pty@0.4.10made both Alpine smoke tests pass.This PR keeps PTY smoke coverage for macOS, glibc Linux, and Windows x64. Alpine and Windows ARM64 continue to run version, model, and artifact checks without claiming PTY support.
Remaining platform and rollout work is tracked in issue #13451.
User Impact
Release validation no longer blocks on PTY checks for unsupported targets. No runtime behavior or user-facing terminal behavior changes in this PR.
Evidence
packages/core/src/kilocode/pty/smoke.ts.This PR is the temporary release-gating fix; issue #13451 remains open for the compatibility work.