fix(vscode): remove top-level Auto-Approve permission on onboarding - #13453
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-4.6 · Input: 254.2K · Output: 18.4K · Cached: 387.2K Review guidance: REVIEW.md from base branch |
marius-kilocode
approved these changes
Aug 26, 2026
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Review-first onboarding no longer writes a top-level
permission["*"]rule. Tool-specific defaults such as Bash Ask remain explicit, so Auto-Approve selections can override onboarding defaults and persist without being shadowed by a global wildcard.The Auto-Approve effective-level calculation is shared with regression tests covering the initial onboarding state and the Ask-to-Allow save flow. Onboarding persistence tests also prevent future presets from writing top-level Ask, Allow, or Deny rules when creating Global Config.
Behavior for new Review-first users
Review-first now configures explicit review boundaries instead of applying Ask to every tool through a global wildcard.
The onboarding preset still asks before:
.envand.env.*files, while allowing.env.example.The preset still allows:
ls,pwd,grep,rg,head, andtail.Tools not listed by the Review-first preset now inherit the CLI’s normal per-tool defaults instead of being forced to Ask by
permission["*"]. This prevents onboarding from silently changing the behavior of every current and future tool, while retaining explicit Ask rules around the operations Review-first is intended to review.Users can subsequently change any displayed Auto-Approve permission from Ask to Allow or Deny. That explicit tool choice becomes effective immediately and remains effective after saving and reloading because there is no generated top-level wildcard that can shadow it.
This PR affects newly applied Review-first presets. It does not rewrite existing Global Config files or remove top-level wildcard rules that users may have authored intentionally.
Closes #13434