Skip to content

fix(vscode): remove top-level Auto-Approve permission on onboarding - #13453

Merged
WebReflection merged 1 commit into
mainfrom
kilo-local-settings
Aug 26, 2026
Merged

fix(vscode): remove top-level Auto-Approve permission on onboarding#13453
WebReflection merged 1 commit into
mainfrom
kilo-local-settings

Conversation

@WebReflection

@WebReflection WebReflection commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What changed

Review-first onboarding no longer writes a top-level permission["*"] rule. Tool-specific defaults such as Bash Ask remain explicit, so Auto-Approve selections can override onboarding defaults and persist without being shadowed by a global wildcard.

The Auto-Approve effective-level calculation is shared with regression tests covering the initial onboarding state and the Ask-to-Allow save flow. Onboarding persistence tests also prevent future presets from writing top-level Ask, Allow, or Deny rules when creating Global Config.

Behavior for new Review-first users

Review-first now configures explicit review boundaries instead of applying Ask to every tool through a global wildcard.

The onboarding preset still asks before:

  • Editing files.
  • Accessing directories outside the workspace, except paths allowed by the CLI defaults.
  • Running Bash commands not covered by the preset’s read-only allowlist, including commands that redirect output.
  • Continuing after a detected doom loop.
  • Reading .env and .env.* files, while allowing .env.example.

The preset still allows:

  • Normal file reads.
  • Glob, Grep, and List discovery operations.
  • Questions.
  • Web Fetch and Web Search.
  • The preset’s read-only Bash commands, such as ls, pwd, grep, rg, head, and tail.

Tools not listed by the Review-first preset now inherit the CLI’s normal per-tool defaults instead of being forced to Ask by permission["*"]. This prevents onboarding from silently changing the behavior of every current and future tool, while retaining explicit Ask rules around the operations Review-first is intended to review.

Users can subsequently change any displayed Auto-Approve permission from Ask to Allow or Deny. That explicit tool choice becomes effective immediately and remains effective after saving and reloading because there is no generated top-level wildcard that can shadow it.

This PR affects newly applied Review-first presets. It does not rewrite existing Global Config files or remove top-level wildcard rules that users may have authored intentionally.

Closes #13434

@kilo-code-bot

kilo-code-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (7 files)
  • .changeset/onboarding-tool-permissions.md
  • packages/kilo-vscode/src/shared/work-style-presets.ts
  • packages/kilo-vscode/tests/unit/permission-editor.test.ts
  • packages/kilo-vscode/tests/unit/work-style-apply.test.ts
  • packages/kilo-vscode/tests/unit/work-style-presets.test.ts
  • packages/kilo-vscode/webview-ui/src/components/settings/PermissionEditor.tsx
  • packages/kilo-vscode/webview-ui/src/components/settings/permission-utils.ts

Reviewed by grok-4.6 · Input: 254.2K · Output: 18.4K · Cached: 387.2K

Review guidance: REVIEW.md from base branch main

@WebReflection
WebReflection merged commit 98278ab into main Aug 26, 2026
24 checks passed
@WebReflection
WebReflection deleted the kilo-local-settings branch August 26, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review-first onboarding can make Auto-Approve permission overrides ineffective

2 participants