fix(agent-manager): allow explicit provider selection - #13419
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Previous Review Summary (commit 78692a7)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 78692a7)Status: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-4.6 · Input: 69.7K · Output: 4.9K · Cached: 193.7K Review guidance: REVIEW.md from base branch |
marius-kilocode
enabled auto-merge
August 25, 2026 13:04
marius-kilocode
disabled auto-merge
August 25, 2026 13:16
marius-kilocode
enabled auto-merge
August 25, 2026 13:16
marius-kilocode
disabled auto-merge
August 25, 2026 13:16
iscekic
reviewed
Aug 25, 2026
iscekic
left a comment
Collaborator
There was a problem hiding this comment.
Approved, ignorable bot remarks below
iscekic
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Agent Manager model-name resolution previously relied on the invoking provider and fallback ranking. Callers could not select a specific provider when the same model name was available from multiple providers.
Why This Change Was Made
Each Agent Manager task now accepts an optional
providerbesidemodel. The provider is trimmed and scoped to the available catalog before exact, name, fuzzy, and variant matching. Unknown providers, provider/model mismatches, provider-only requests, and malformed provider values fail safely without requesting Agent Manager permission.Model-only requests keep the existing inherited-provider preference and deterministic tie-break behavior. The resolved event still carries only the concrete model reference, so protocol and SDK artifacts do not need regeneration.
User Impact
Callers can use
tasks[].providerwith a model name to force a provider, for example{ "model": "Shared", "provider": "anthropic" }. Model search output and Agent Manager documentation describe the new field and provider IDs.Evidence
bun test test/kilocode/agent-manager-tool.test.ts test/kilocode/agent-manager-models-tool.test.tsfrompackages/opencode, 43 tests passed.bun run typecheckfrompackages/opencodepassed.bun run lintpassed with zero errors and existing warnings.bun run script/check-opencode-annotations.ts --worktreepassed.