Skip to content

fix(agent-manager): use valid terminal close code #13416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marius-kilocode merged 1 commit into from
Aug 25, 2026
Merged

fix(agent-manager): use valid terminal close code #13416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/terminal-replay-close-code.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"kilo-code": patch
---

Use a browser-valid close code when Agent Manager terminal replay exceeds its buffer limit
5 changes: 5 additions & 0 deletions packages/kilo-vscode/tests/unit/agent-manager-terminal-layout.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,11 @@ test("orders local terminal status lines through the output batcher", () => {
expect(terminal).not.toContain("term.writeln(")
})

test("uses a browser-valid close code when replay overflows", () => {
expect(terminal).not.toContain("close(1009,")
expect(terminal).toContain('close(4009, "terminal replay exceeded limit")')
})

test("keeps raw PTY line endings and initializes Unicode widths before attaching", () => {
expect(terminal).toContain("convertEol: false")
expect(terminal).toContain('term.unicode.activeVersion = "15-graphemes"')
Expand Down
4 changes: 2 additions & 2 deletions packages/kilo-vscode/webview-ui/agent-manager/terminal/TerminalTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ export const TerminalTab: Component<Props> = (props) => {
if (typeof event.data === "string") {
if (!replay.output(event.data)) {
input.clear()
next.close(1009, "terminal replay exceeded limit")
next.close(4009, "terminal replay exceeded limit")
return
}
scheduleFlush()
Expand All @@ -345,7 +345,7 @@ export const TerminalTab: Component<Props> = (props) => {
if (replay.frame(bytes)) return
if (!replay.output(bytes)) {
input.clear()
next.close(1009, "terminal replay exceeded limit")
next.close(4009, "terminal replay exceeded limit")
return
}
scheduleFlush()
Expand Down
Loading